Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2809123004: [MD settings] keep radio button circles circular (Closed)

Created:
3 years, 8 months ago by dschuyler
Modified:
3 years, 8 months ago
Reviewers:
Dan Beam, hcarmona
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] keep radio button circles circular This CL prevents the 'circle part' of a radio button from 'flex shrinking' when the label for the button gets too big (creating a kind of pressure on the radio button). BUG=705479 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2809123004 Cr-Commit-Position: refs/heads/master@{#464089} Committed: https://chromium.googlesource.com/chromium/src/+/03e0ed84b42ebd642fe7f517b2d8eda18ebb13e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/resources/settings/settings_shared_css.html View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
dschuyler
3 years, 8 months ago (2017-04-12 01:30:52 UTC) #4
Dan Beam
lgtm
3 years, 8 months ago (2017-04-12 01:32:40 UTC) #7
hcarmona
lgtm
3 years, 8 months ago (2017-04-12 17:16:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2809123004/1
3 years, 8 months ago (2017-04-12 17:33:25 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 18:16:27 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/03e0ed84b42ebd642fe7f517b2d8...

Powered by Google App Engine
This is Rietveld 408576698