Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2809103002:
ur_ls -> urls in ResourceFetcher (Closed)
|
Created:
3 years, 8 months ago by kouhei (in TOK) Modified:
3 years, 8 months ago CC:
chromium-reviews, tyoshino+watch_chromium.org, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, kinuko+watch, Nate Chapin Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Descriptionur_ls -> urls in ResourceFetcher
Blink Reformat miss? fix
BUG=675877
Review-Url: https://codereview.chromium.org/2809103002
Cr-Commit-Position: refs/heads/master@{#463599}
Committed: https://chromium.googlesource.com/chromium/src/+/4fdb2b3ebb31e39852fb1bc20fcdf3b5e4de382e
Patch Set 1 #
Messages
Total messages: 23 (13 generated)
kouhei@chromium.org changed reviewers: + toyoshim@chromium.org
The CQ bit was checked by kouhei@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
dcheng@chromium.org changed reviewers: + dcheng@chromium.org
LGTM Thanks for fixing this. I'm guessing the original variable was named m_validatedURLs, which confuses the renaming logic. Also, mind adding BUG=675877 for tracking purposes?
Description was changed from ========== ur_ls -> urls in ResourceFetcher Blink Reformat miss? fix BUG=None ========== to ========== ur_ls -> urls in ResourceFetcher Blink Reformat miss? fix BUG=675877 ==========
(Looks like there's a few more elsewhere: https://cs.chromium.org/search/?q=%22ur_ls%22+package:%5Echromium$+file:third.... I'll fix them tomorrow if no one else gets to them)
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by kouhei@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
kouhei@chromium.org changed reviewers: + haraken@chromium.org
haraken: can i have your rs?
LGTM
The CQ bit was checked by kouhei@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1491911045699740, "parent_rev":
"14cd5f73bdedb05dd26b40028402ae195727061d", "commit_rev":
"4fdb2b3ebb31e39852fb1bc20fcdf3b5e4de382e"}
Message was sent while issue was closed.
Description was changed from ========== ur_ls -> urls in ResourceFetcher Blink Reformat miss? fix BUG=675877 ========== to ========== ur_ls -> urls in ResourceFetcher Blink Reformat miss? fix BUG=675877 Review-Url: https://codereview.chromium.org/2809103002 Cr-Commit-Position: refs/heads/master@{#463599} Committed: https://chromium.googlesource.com/chromium/src/+/4fdb2b3ebb31e39852fb1bc20fcd... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/4fdb2b3ebb31e39852fb1bc20fcd... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
