Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2809053002:
Filter out shorthands for make_computed_style_base.py. (Closed)
|
Created:
3 years, 8 months ago by shend Modified:
3 years, 8 months ago Reviewers:
alancutter (OOO until 2018) CC:
blink-reviews, chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionFilter out shorthands for make_computed_style_base.py.
This patch filters out shorthands from the input of
make_computed_style_base. This is to explictly prevent shorthands being
treated like CSS properties in ComputedStyle.
Currently there are no shorthands being generated as properties, so this
patch does not affect behaviour.
BUG=628043
Review-Url: https://codereview.chromium.org/2809053002
Cr-Commit-Position: refs/heads/master@{#464307}
Committed: https://chromium.googlesource.com/chromium/src/+/ff28dbc9cb80d5f00fd39c3bd780c7cd83d8089a
Patch Set 1 #Patch Set 2 : Add asserts #Messages
Total messages: 22 (18 generated)
shend@chromium.org changed reviewers: + alancutter@chromium.org
Hi Alan, PTAL :) WDYT of an assert instead of filtering?
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/04/11 at 02:11:52, shend wrote: > Hi Alan, PTAL :) WDYT of an assert instead of filtering? An assert in addition sounds like a good idea. lgtm.
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by shend@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from alancutter@chromium.org Link to the patchset: https://codereview.chromium.org/2809053002/#ps20001 (title: "Add asserts")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492060187838690,
"parent_rev": "df9a1e9283950cdbeaccfbd83587d424f4dc2436", "commit_rev":
"ff28dbc9cb80d5f00fd39c3bd780c7cd83d8089a"}
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492060187838690,
"parent_rev": "df9a1e9283950cdbeaccfbd83587d424f4dc2436", "commit_rev":
"ff28dbc9cb80d5f00fd39c3bd780c7cd83d8089a"}
Message was sent while issue was closed.
Description was changed from ========== Filter out shorthands for make_computed_style_base.py. This patch filters out shorthands from the input of make_computed_style_base. This is to explictly prevent shorthands being treated like CSS properties in ComputedStyle. Currently there are no shorthands being generated as properties, so this patch does not affect behaviour. BUG=628043 ========== to ========== Filter out shorthands for make_computed_style_base.py. This patch filters out shorthands from the input of make_computed_style_base. This is to explictly prevent shorthands being treated like CSS properties in ComputedStyle. Currently there are no shorthands being generated as properties, so this patch does not affect behaviour. BUG=628043 Review-Url: https://codereview.chromium.org/2809053002 Cr-Commit-Position: refs/heads/master@{#464307} Committed: https://chromium.googlesource.com/chromium/src/+/ff28dbc9cb80d5f00fd39c3bd780... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/ff28dbc9cb80d5f00fd39c3bd780... |
