Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: tools/binary_size/create_html_breakdown.py

Issue 2809043003: //tools/binary_size: Group [clone] and ** symbols (Closed)
Patch Set: review comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/binary_size/console.py ('k') | tools/binary_size/describe.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/binary_size/create_html_breakdown.py
diff --git a/tools/binary_size/create_html_breakdown.py b/tools/binary_size/create_html_breakdown.py
index 44a6d1111d31d2a44805a4d4a693a51ab9209535..ad278b279a9778f53e6a09799f424d936acfb32f 100755
--- a/tools/binary_size/create_html_breakdown.py
+++ b/tools/binary_size/create_html_breakdown.py
@@ -14,7 +14,6 @@ import sys
import helpers
import map2size
-import paths
# Node dictionary keys. These are output in json read by the webapp so
@@ -167,8 +166,7 @@ def _CopyTemplateFiles(dest_dir):
def main(argv):
parser = argparse.ArgumentParser()
parser.add_argument('input_file',
- help='Path to input file. Can be a linker .map file, or '
- 'a .size file.')
+ help='Path to input .size file.')
parser.add_argument('--report-dir', metavar='PATH', required=True,
help='Write output to the specified directory. An HTML '
'report is generated here.')
@@ -177,11 +175,9 @@ def main(argv):
'space)')
parser.add_argument('--include-symbols', action='store_true',
help='Use per-symbol granularity rather than per-file.')
- paths.AddOptions(parser)
args = helpers.AddCommonOptionsAndParseArgs(parser, argv)
- lazy_paths = paths.LazyPaths(args=args, input_file=args.input_file)
- size_info = map2size.Analyze(args.input_file, lazy_paths)
+ size_info = map2size.LoadAndPostProcessSizeInfo(args.input_file)
symbols = size_info.symbols
if not args.include_bss:
symbols = symbols.WhereInSection('b').Inverted()
« no previous file with comments | « tools/binary_size/console.py ('k') | tools/binary_size/describe.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698