Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: tools/binary_size/console.py

Issue 2809043003: //tools/binary_size: Group [clone] and ** symbols (Closed)
Patch Set: review comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/binary_size/create_html_breakdown.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/binary_size/console.py
diff --git a/tools/binary_size/console.py b/tools/binary_size/console.py
index b354a68b103da061b7468ea1a5165985e039c307..53f760661942e95669846f08c5ef0d149976f20d 100755
--- a/tools/binary_size/console.py
+++ b/tools/binary_size/console.py
@@ -93,17 +93,19 @@ class _Session(object):
self._variables['size_info%d' % (i + 1)] = size_info
self._variables['symbols%d' % (i + 1)] = size_info.symbols
- def _PrintFunc(self, obj, verbose=False, use_pager=None, to_file=None):
+ def _PrintFunc(self, obj, verbose=False, recursive=False, use_pager=None,
+ to_file=None):
"""Prints out the given Symbol / SymbolGroup / SymbolDiff / SizeInfo.
Args:
obj: The object to be printed.
verbose: Show more detailed output.
+ recursive: Print children of nested SymbolGroups.
use_pager: Pipe output through `less`. Ignored when |obj| is a Symbol.
default is to automatically pipe when output is long.
to_file: Rather than print to stdio, write to the given file.
"""
- lines = describe.GenerateLines(obj, verbose=verbose)
+ lines = describe.GenerateLines(obj, verbose=verbose, recursive=recursive)
_WriteToStream(lines, use_pager=use_pager, to_file=to_file)
def _ElfPathForSymbol(self, symbol):
@@ -245,7 +247,7 @@ def main(argv):
if not path.endswith('.size'):
parser.error('All inputs must end with ".size"')
- size_infos = [map2size.Analyze(p) for p in args.inputs]
+ size_infos = [map2size.LoadAndPostProcessSizeInfo(p) for p in args.inputs]
lazy_paths = paths.LazyPaths(args=args, input_file=args.inputs[0])
session = _Session(size_infos, lazy_paths)
« no previous file with comments | « no previous file | tools/binary_size/create_html_breakdown.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698