EME contentType checks DolbyVision

chromecast/renderer/media/key_systems_cast.cc

Index: chromecast/renderer/media/key_systems_cast.cc
diff --git a/chromecast/renderer/media/key_systems_cast.cc b/chromecast/renderer/media/key_systems_cast.cc
index 1e297151fd06ad7a88211ba6ce294a8289b87e62..df31180a67cac149915b17371da4fa42df1eee66 100644
--- a/chromecast/renderer/media/key_systems_cast.cc
+++ b/chromecast/renderer/media/key_systems_cast.cc
@@ -49,6 +49,12 @@ class PlayReadyKeySystemProperties : public ::media::KeySystemProperties {
 #if BUILDFLAG(ENABLE_HEVC_DEMUXING)
     codecs |= ::media::EME_CODEC_MP4_HEVC;
 #endif
+#if BUILDFLAG(ENABLE_DOLBY_VISION_DEMUXING)
+    codecs |= ::media::EME_CODEC_MP4_DV_AVC;

[chcunningham, 2017/04/17 16:14:24]

Its not easy for me to verify playready supports these. Have you checked it?

[yucliu1, 2017/04/18 00:13:02]

I'll verify this soon. Chromecast Ultra supports DV.

[yucliu1, 2017/04/19 04:34:25]

I can verify the reqestMediaKeySystemAccess returns pending promise for
Playready + DV. Since cast doesn't distinguish between secure vs non secure
codecs, playback also works.

However, although type check passes both MediaSource.isTypeSupported and
requestMediaKeySystemAccess, DV content may not be able to play on the screen if
TV doesn't support DV. Is this the expected behavior? (We have additional API to
check whether the content can be  played on screen)

+#if BUILDFLAG(ENABLE_HEVC_DEMUXING)
+    codecs |= ::media::EME_CODEC_MP4_DV_HEVC;
+#endif
+#endif
     return codecs;
   }
 
@@ -111,6 +117,12 @@ void AddChromecastKeySystems(
 #if BUILDFLAG(ENABLE_HEVC_DEMUXING)
   codecs |= ::media::EME_CODEC_MP4_HEVC;
 #endif
+#if BUILDFLAG(ENABLE_DOLBY_VISION_DEMUXING)
+  codecs |= ::media::EME_CODEC_MP4_DV_AVC;

[chcunningham, 2017/04/17 16:14:24]

Ditto here. I'm not sure how to verify Widevine actually has this support. How
can I verify?

[yucliu1, 2017/04/18 00:13:01]

I have tried some DV codecs with Widevine on Chromecast Ultra, it works as
expected, I can double check that.

+#if BUILDFLAG(ENABLE_HEVC_DEMUXING)
+  codecs |= ::media::EME_CODEC_MP4_DV_HEVC;
+#endif
+#endif
   key_systems_properties->emplace_back(new cdm::WidevineKeySystemProperties(
       codecs,                     // Regular codecs.
       Robustness::HW_SECURE_ALL,  // Max audio robustness.