EME contentType checks DolbyVision

chromecast/renderer/media/key_systems_cast.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/renderer/media/key_systems_cast.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/logging.h"
@@ skipping 31 matching lines @@
   bool IsSupportedInitDataType(EmeInitDataType init_data_type) const override {
     return init_data_type == EmeInitDataType::CENC;
   }
 
   SupportedCodecs GetSupportedCodecs() const override {
     SupportedCodecs codecs =
         ::media::EME_CODEC_MP4_AAC | ::media::EME_CODEC_MP4_AVC1;
 #if BUILDFLAG(ENABLE_HEVC_DEMUXING)
     codecs |= ::media::EME_CODEC_MP4_HEVC;
 #endif
+#if BUILDFLAG(ENABLE_DOLBY_VISION_DEMUXING)
+    codecs |= ::media::EME_CODEC_MP4_DV_AVC;

[chcunningham, 2017/04/17 16:14:24]

Its not easy for me to verify playready supports these. Have you checked it?

[yucliu1, 2017/04/18 00:13:02]

I'll verify this soon. Chromecast Ultra supports DV.

[yucliu1, 2017/04/19 04:34:25]

I can verify the reqestMediaKeySystemAccess returns pending promise for
Playready + DV. Since cast doesn't distinguish between secure vs non secure
codecs, playback also works.

However, although type check passes both MediaSource.isTypeSupported and
requestMediaKeySystemAccess, DV content may not be able to play on the screen if
TV doesn't support DV. Is this the expected behavior? (We have additional API to
check whether the content can be  played on screen)

+#if BUILDFLAG(ENABLE_HEVC_DEMUXING)
+    codecs |= ::media::EME_CODEC_MP4_DV_HEVC;
+#endif
+#endif
     return codecs;
   }
 
   EmeConfigRule GetRobustnessConfigRule(
       EmeMediaType media_type,
       const std::string& requested_robustness) const override {
     return requested_robustness.empty() ? EmeConfigRule::SUPPORTED
                                         : EmeConfigRule::NOT_SUPPORTED;
   }
 
@@ skipping 42 matching lines @@
   cdm::AddAndroidWidevine(key_systems_properties);
 #else
   using Robustness = cdm::WidevineKeySystemProperties::Robustness;
   ::media::SupportedCodecs codecs =
       ::media::EME_CODEC_MP4_AAC | ::media::EME_CODEC_MP4_AVC1 |
       ::media::EME_CODEC_MP4_VP9 | ::media::EME_CODEC_WEBM_VP8 |
       ::media::EME_CODEC_WEBM_VP9;
 #if BUILDFLAG(ENABLE_HEVC_DEMUXING)
   codecs |= ::media::EME_CODEC_MP4_HEVC;
 #endif
+#if BUILDFLAG(ENABLE_DOLBY_VISION_DEMUXING)
+  codecs |= ::media::EME_CODEC_MP4_DV_AVC;

[chcunningham, 2017/04/17 16:14:24]

Ditto here. I'm not sure how to verify Widevine actually has this support. How
can I verify?

[yucliu1, 2017/04/18 00:13:01]

I have tried some DV codecs with Widevine on Chromecast Ultra, it works as
expected, I can double check that.

+#if BUILDFLAG(ENABLE_HEVC_DEMUXING)
+  codecs |= ::media::EME_CODEC_MP4_DV_HEVC;
+#endif
+#endif
   key_systems_properties->emplace_back(new cdm::WidevineKeySystemProperties(
       codecs,                     // Regular codecs.
       Robustness::HW_SECURE_ALL,  // Max audio robustness.
       Robustness::HW_SECURE_ALL,  // Max video robustness.
       enable_persistent_license_support
           ? EmeSessionTypeSupport::SUPPORTED
           : EmeSessionTypeSupport::NOT_SUPPORTED,  // persistent-license.
       EmeSessionTypeSupport::NOT_SUPPORTED,  // persistent-release-message.
       // Note: On Chromecast, all CDMs may have persistent state.
       EmeFeatureSupport::ALWAYS_ENABLED,    // Persistent state.
       EmeFeatureSupport::ALWAYS_ENABLED));  // Distinctive identifier.
 #endif  // defined(OS_ANDROID)
 #endif  // defined(WIDEVINE_CDM_AVAILABLE)
 }
 
 }  // namespace media
 }  // namespace chromecast