Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2809003007: [DevTools] Reset main frame subtree on navigation (Closed)

Created:
3 years, 8 months ago by eostroukhov
Modified:
3 years, 8 months ago
Reviewers:
caseq, dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Reset main frame subtree on navigation BUG=710664 Review-Url: https://codereview.chromium.org/2809003007 Cr-Commit-Position: refs/heads/master@{#464098} Committed: https://chromium.googlesource.com/chromium/src/+/965189d07248dbb0300f0ba4a9eaae6b51ff3d4d

Patch Set 1 #

Patch Set 2 : [DevTools] Reset main frame subtree on navigation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/resources/resources-panel-on-navigation-expected.txt View 1 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/ResourcesSection.js View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
eostroukhov
Please take a look.
3 years, 8 months ago (2017-04-11 23:59:19 UTC) #4
dgozman
lgtm Do we need to merge this to M58?
3 years, 8 months ago (2017-04-12 18:27:25 UTC) #7
eostroukhov
On 2017/04/12 18:27:25, dgozman wrote: > lgtm > > Do we need to merge this ...
3 years, 8 months ago (2017-04-12 18:37:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2809003007/20001
3 years, 8 months ago (2017-04-12 18:37:54 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 19:24:50 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/965189d07248dbb0300f0ba4a9ea...

Powered by Google App Engine
This is Rietveld 408576698