🏠 Fix coloring issues in status bar

[Home] Fix coloring issues in status bar

This change fixes two problems:

- The Android api levels that allow changing of the status bar
  background and the level that allows status bar "light mode" for
  the icons is different. Any version of Android below M will now use
  black as the status bar color if Chrome Home is enabled.

- The system UI flag indicating whether or not the status bar was in
  "light mode" was never reset when viewing the tab switcher or
  incognito NTP. This change removes the flag in those cases.

All the status bar color logic now lives in BottomSheet.java, making
ChromeTabbedActivity easier to read.

BUG=710084, 708680
Review-Url: https://codereview.chromium.org/2809003006
Cr-Commit-Position: refs/heads/master@{#463785}
Committed: https://chromium.googlesource.com/chromium/src/+/54c4473401a83a2e700d39cf3ee0fee91eb198fc

[mdjones, 2017-04-11 16:42:50]

Description was changed from

==========
[Home] Fix coloring issues in status bar

This change fixes two problems:

- The Android api levels that allow changing of the status bar
  background and the level that allows status bar "light mode" for
  the icons is different. Any version of Android below M will now use
  black as the status bar color if Chrome Home is enabled.

- The system UI flag indicating whether or not the status bar was in
  "light mode" was never reset when viewing the tab switcher or
  incognito NTP. This change removes the flag in those cases.

All the status bar color logic now lives in BottomSheet.java, making
ChromeTabbedActivity easier to read.

BUG=710084, 708680
==========

to

==========
[Home] Fix coloring issues in status bar

This change fixes two problems:

- The Android api levels that allow changing of the status bar
  background and the level that allows status bar "light mode" for
  the icons is different. Any version of Android below M will now use
  black as the status bar color if Chrome Home is enabled.

- The system UI flag indicating whether or not the status bar was in
  "light mode" was never reset when viewing the tab switcher or
  incognito NTP. This change removes the flag in those cases.

All the status bar color logic now lives in BottomSheet.java, making
ChromeTabbedActivity easier to read.

BUG=710084, 708680
==========

[mdjones, 2017-04-11 16:43:24]

mdjones@chromium.org changed reviewers:
+ twellington@chromium.org

[mdjones, 2017-04-11 16:43:24]

ptal

[Theresa, 2017-04-11 17:08:42]

lgtm

[mdjones, 2017-04-11 18:10:41]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2017-04-11 18:10:43]

The CQ bit was unchecked by mdjones@chromium.org

[mdjones, 2017-04-11 18:11:02]

mdjones@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[mdjones, 2017-04-11 18:11:02]

dfalcantara: owners

[gone, 2017-04-11 18:36:22]

lgtm

[mdjones, 2017-04-11 20:57:03]

The CQ bit was checked by mdjones@chromium.org

[commit-bot: I haz the power, 2017-04-11 20:59:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 21:49:20]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491944223621920, "parent_rev":
"6a532063ea0cd85c3934bcbf19037dc87a57abeb", "commit_rev":
"54c4473401a83a2e700d39cf3ee0fee91eb198fc"}

[commit-bot: I haz the power, 2017-04-11 21:50:16]

Description was changed from

==========
[Home] Fix coloring issues in status bar

This change fixes two problems:

- The Android api levels that allow changing of the status bar
  background and the level that allows status bar "light mode" for
  the icons is different. Any version of Android below M will now use
  black as the status bar color if Chrome Home is enabled.

- The system UI flag indicating whether or not the status bar was in
  "light mode" was never reset when viewing the tab switcher or
  incognito NTP. This change removes the flag in those cases.

All the status bar color logic now lives in BottomSheet.java, making
ChromeTabbedActivity easier to read.

BUG=710084, 708680
==========

to

==========
[Home] Fix coloring issues in status bar

This change fixes two problems:

- The Android api levels that allow changing of the status bar
  background and the level that allows status bar "light mode" for
  the icons is different. Any version of Android below M will now use
  black as the status bar color if Chrome Home is enabled.

- The system UI flag indicating whether or not the status bar was in
  "light mode" was never reset when viewing the tab switcher or
  incognito NTP. This change removes the flag in those cases.

All the status bar color logic now lives in BottomSheet.java, making
ChromeTabbedActivity easier to read.

BUG=710084, 708680

Review-Url: https://codereview.chromium.org/2809003006
Cr-Commit-Position: refs/heads/master@{#463785}
Committed:
https://chromium.googlesource.com/chromium/src/+/54c4473401a83a2e700d39cf3ee0...
==========

[commit-bot: I haz the power, 2017-04-11 21:50:17]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/54c4473401a83a2e700d39cf3ee0...