third_party/WebKit/Source/bindings/core/v8/NativeValueTraitsImplTest.cpp - Issue 2809003004: bindings: Use ExceptionMessages when an interface/callback conversion fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/NativeValueTraitsImplTest.cpp

Issue 2809003004: bindings: Use ExceptionMessages when an interface/callback conversion fails. (Closed)

Patch Set: Add ExceptionMessages::FailedToConvertJSValue Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.cpp ('k') | third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/NativeValueTraitsImplTest.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/NativeValueTraitsImplTest.cpp b/third_party/WebKit/Source/bindings/core/v8/NativeValueTraitsImplTest.cpp

index b6e750d8a83182867cc0b9eff281803b19c09c36..062d7fff725f70eb1bd56dc53213dbb83b05069c 100644

--- a/third_party/WebKit/Source/bindings/core/v8/NativeValueTraitsImplTest.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/NativeValueTraitsImplTest.cpp

@@ -31,7 +31,7 @@ TEST(NativeValueTraitsImplTest, IDLInterface) {

scope.GetIsolate(), v8::Number::New(scope.GetIsolate(), 42),

exception_state);

EXPECT_TRUE(exception_state.HadException());

- EXPECT_EQ("Unable to convert value to Internals.",

+ EXPECT_EQ("Failed to convert value to 'Internals'.",

exception_state.Message());

EXPECT_EQ(nullptr, internals);

}

@@ -42,7 +42,7 @@ TEST(NativeValueTraitsImplTest, IDLInterface) {

scope.GetIsolate(), v8::Undefined(scope.GetIsolate()),

exception_state);

EXPECT_TRUE(exception_state.HadException());

- EXPECT_EQ("Unable to convert value to TestSequenceCallback.",

+ EXPECT_EQ("Failed to convert value to 'TestSequenceCallback'.",

exception_state.Message());

EXPECT_EQ(nullptr, callback_function);

}