third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.cpp - Issue 2809003004: bindings: Use ExceptionMessages when an interface/callback conversion fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.cpp

Issue 2809003004: bindings: Use ExceptionMessages when an interface/callback conversion fails. (Closed)

Patch Set: Add ExceptionMessages::FailedToConvertJSValue Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.cpp b/third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.cpp

index c145537a7b1e30b20f13387463fd20a9ccde5cd6..a075ee1c2a83dc15b8ac9c8d1b55dc89b0766fa3 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.cpp

@@ -35,6 +35,10 @@

namespace blink {

+String ExceptionMessages::FailedToConvertJSValue(const char* type) {

+ return String::Format("Failed to convert value to '%s'.", type);

String ExceptionMessages::FailedToConstruct(const char* type,

const String& detail) {

return "Failed to construct '" + String(type) +