Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: chrome/browser/ui/bookmarks/bookmark_utils_desktop.h

Issue 2809003002: Making bookmark folder context menu display the number of bookmarks that will be opened by Open All (Closed)
Patch Set: Refactoring URL itteration function as per comments, addressing other formatting and style errors Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/bookmarks/bookmark_utils_desktop.h
diff --git a/chrome/browser/ui/bookmarks/bookmark_utils_desktop.h b/chrome/browser/ui/bookmarks/bookmark_utils_desktop.h
index 062817bd9367af76de9b86e2116c5bb296f96392..8776e94e9effe179cd0ada650a50931572088e05 100644
--- a/chrome/browser/ui/bookmarks/bookmark_utils_desktop.h
+++ b/chrome/browser/ui/bookmarks/bookmark_utils_desktop.h
@@ -47,6 +47,20 @@ void OpenAll(gfx::NativeWindow parent,
WindowOpenDisposition initial_disposition,
content::BrowserContext* browser_context);
+// Returns the count of bookmarks that would be opened by OpenAll. If
+// |incognito| is true, the function will use |browser_context| to check if the
+// URLs can be opened in incognito mode, which may affect the count.
+int OpenCount(gfx::NativeWindow parent,
+ const std::vector<const bookmarks::BookmarkNode*>& nodes,
+ bool incognito = false,
+ content::BrowserContext* browser_context = NULL);
Peter Kasting 2017/04/14 08:17:15 Nit: NULL -> nullptr (everywhere in CL)
Paezagon 2017/04/14 18:47:24 Done.
+
+// Convenience for OpenCount() with a single BookmarkNode.
Peter Kasting 2017/04/14 08:17:15 Nit: Maybe we shouldn't add this, and BookmarkMenu
Paezagon 2017/04/14 18:47:24 I would rather keep it consistent with the OpenAll
+int OpenCount(gfx::NativeWindow parent,
+ const bookmarks::BookmarkNode* node,
+ bool incognito = false,
+ content::BrowserContext* browser_context = NULL);
+
// Asks the user before deleting a non-empty bookmark folder.
bool ConfirmDeleteBookmarkNode(const bookmarks::BookmarkNode* node,
gfx::NativeWindow window);

Powered by Google App Engine
This is Rietveld 408576698