Making bookmark folder context menu display the number of bookmarks that will be opened by Open All

chrome/browser/ui/bookmarks/bookmark_utils_desktop.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_BOOKMARKS_BOOKMARK_UTILS_DESKTOP_H_
 #define CHROME_BROWSER_UI_BOOKMARKS_BOOKMARK_UTILS_DESKTOP_H_
 
 #include <vector>
 
 #include "ui/base/window_open_disposition.h"
@@ skipping 29 matching lines @@
              WindowOpenDisposition initial_disposition,
              content::BrowserContext* browser_context);
 
 // Convenience for OpenAll() with a single BookmarkNode.
 void OpenAll(gfx::NativeWindow parent,
              content::PageNavigator* navigator,
              const bookmarks::BookmarkNode* node,
              WindowOpenDisposition initial_disposition,
              content::BrowserContext* browser_context);
 
+// Returns the count of bookmarks that would be opened by OpenAll. If
+// |incognito| is true, the function will use |browser_context| to check if the
+// URLs can be opened in incognito mode, which may affect the count.
+int OpenCount(gfx::NativeWindow parent,
+              const std::vector<const bookmarks::BookmarkNode*>& nodes,
+              bool incognito = false,
+              content::BrowserContext* browser_context = NULL);

[Peter Kasting, 2017/04/14 08:17:15]

Nit: NULL -> nullptr (everywhere in CL)

[Paezagon, 2017/04/14 18:47:24]

Done.

+
+// Convenience for OpenCount() with a single BookmarkNode.

[Peter Kasting, 2017/04/14 08:17:15]

Nit: Maybe we shouldn't add this, and BookmarkMenuBridge::AddItemToMenu() should
just create the nodes vector itself?

[Paezagon, 2017/04/14 18:47:24]

I would rather keep it consistent with the OpenAll functions.  

+int OpenCount(gfx::NativeWindow parent,
+              const bookmarks::BookmarkNode* node,
+              bool incognito = false,
+              content::BrowserContext* browser_context = NULL);
+
 // Asks the user before deleting a non-empty bookmark folder.
 bool ConfirmDeleteBookmarkNode(const bookmarks::BookmarkNode* node,
                                gfx::NativeWindow window);
 
 // Shows the bookmark all tabs dialog.
 void ShowBookmarkAllTabsDialog(Browser* browser);
 
 // Returns true if OpenAll() can open at least one bookmark of type url
 // in |selection|.
 bool HasBookmarkURLs(
     const std::vector<const bookmarks::BookmarkNode*>& selection);
 
 // Returns true if OpenAll() can open at least one bookmark of type url
 // in |selection| with incognito mode.
 bool HasBookmarkURLsAllowedInIncognitoMode(
     const std::vector<const bookmarks::BookmarkNode*>& selection,
     content::BrowserContext* browser_context);
 
 }  // namespace chrome
 
 #endif  // CHROME_BROWSER_UI_BOOKMARKS_BOOKMARK_UTILS_DESKTOP_H_