Issue 28090: Keeping track of whether WebKit is in the callstack using RenderThread doesn'...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 28090: Keeping track of whether WebKit is in the callstack using RenderThread doesn'... (Closed)

Created:
11 years, 10 months ago by jam

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Keeping track of whether WebKit is in the callstack using RenderThread doesn't work when there are Send calls to plugins (i.e. Gears). So instead, just use PostNonNestableTask to delete RenderWidget. I (Note I still don't know how my change affected this, it seems to have been broken before as well.) BUG=7951 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10298

Patch Set 1 #

Total comments: 1

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -104 lines)			Patch
M	chrome/common/child_process.cc	View	1 chunk	+0 lines, -4 lines	1 comment	Download
M	chrome/common/child_thread.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	chrome/common/child_thread.cc	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	chrome/renderer/mock_render_thread.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/renderer/render_thread.h	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	chrome/renderer/render_widget.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/renderer/render_widget.cc	View	3 chunks	+8 lines, -75 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

LGTM except for... http://codereview.chromium.org/28090/diff/1/4 File chrome/common/child_process.cc (left): http://codereview.chromium.org/28090/diff/1/4#oldcode37 Line 37: child_thread_.reset(); can you explain why ...

11 years, 10 months ago (2009-02-24 22:11:43 UTC) #2

LGTM

Expand Messages | Collapse Messages