chrome/common/child_process.cc - Issue 28090: Keeping track of whether WebKit is in the callstack using RenderThread doesn'...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/child_process.cc

Issue 28090: Keeping track of whether WebKit is in the callstack using RenderThread doesn'... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 11 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/child_process.cc

===================================================================

--- chrome/common/child_process.cc (revision 10288)

+++ chrome/common/child_process.cc (working copy)

@@ -32,10 +32,6 @@

if (child_thread_.get())

child_thread_->Stop();

- // Make sure the child thread goes away first before setting child_process_ to

- // NULL since it can use it.

- child_thread_.reset();

darin (slow to review) 2009/02/24 22:11:43 can you explain why this change is made?

child_process_ = NULL;

}

« no previous file with comments | « no previous file | chrome/common/child_thread.h » ('j') | no next file with comments »