Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2808973002:
Additional CL to Issue 2795603002 (Closed)
|
Created:
3 years, 8 months ago by weidongg Modified:
3 years, 8 months ago Reviewers:
Lei Zhang CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd a comment to AddAboutStrings() to improve code readability.
This is a follow up to issue 2795603002.
BUG=691108
Review-Url: https://codereview.chromium.org/2808973002
Cr-Commit-Position: refs/heads/master@{#463393}
Committed: https://chromium.googlesource.com/chromium/src/+/7a17a8d3a410e7b176e7213e9d27637cc8bdd035
Patch Set 1 #
Messages
Total messages: 17 (9 generated)
weidongg@chromium.org changed reviewers: + thestig@chromium.org
I applied the fix you mentioned in the comment of issue 2795603002.
lgtm
Though please change the CL description to briefly what this CL actually does.
Description was changed from ========== Additional CL to Issue 2795603002 modified: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc BUG=691108 ========== to ========== Additional CL to Issue 2795603002 Add a comment to improve code readability. modified: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc BUG=691108 ==========
The CQ bit was checked by weidongg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by thestig@chromium.org
Description was changed from ========== Additional CL to Issue 2795603002 Add a comment to improve code readability. modified: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc BUG=691108 ========== to ========== Add a comment to AddAboutStrings() to improve code readability. BUG=691108 ==========
Description was changed from ========== Add a comment to AddAboutStrings() to improve code readability. BUG=691108 ========== to ========== Add a comment to AddAboutStrings() to improve code readability. This is a follow up to issue 2795603002. BUG=691108 ==========
Updated CL description. There's no need to have the list of modified files in the CL description. That's redundant.
The CQ bit was checked by thestig@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/04/10 20:22:12, Lei Zhang wrote: > Updated CL description. There's no need to have the list of modified files in > the CL description. That's redundant. Ok, thx.
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1491855736775340, "parent_rev":
"a9aa4cd8b9f3423d372cf440c0e7eb00b49ab026", "commit_rev":
"7a17a8d3a410e7b176e7213e9d27637cc8bdd035"}
Message was sent while issue was closed.
Description was changed from ========== Add a comment to AddAboutStrings() to improve code readability. This is a follow up to issue 2795603002. BUG=691108 ========== to ========== Add a comment to AddAboutStrings() to improve code readability. This is a follow up to issue 2795603002. BUG=691108 Review-Url: https://codereview.chromium.org/2808973002 Cr-Commit-Position: refs/heads/master@{#463393} Committed: https://chromium.googlesource.com/chromium/src/+/7a17a8d3a410e7b176e7213e9d27... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/7a17a8d3a410e7b176e7213e9d27... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
