Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 2808943002: Revert of Fix a linker error when building content_unittests (Closed)

Created:
3 years, 8 months ago by AndyWu
Modified:
3 years, 8 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix a linker error when building content_unittests (patchset #1 id:1 of https://codereview.chromium.org/2807743002/ ) Reason for revert: The issue should be fixed already with the CL: https://codereview.chromium.org/2792293002. Original issue's description: > Fix a linker error when building content_unittests > > When building content_unittests for Cast on Android with mojo_media_host > as "browser", linker complains media::MojoRendererService::Create() is > undefined. Add //media/mojo/services as a dependency when > enable_mojo_media is true to resolve the error. > > BUG=Internal b/37086171 > > Review-Url: https://codereview.chromium.org/2807743002 > Cr-Commit-Position: refs/heads/master@{#463310} > Committed: https://chromium.googlesource.com/chromium/src/+/9ebda5bc1beadd3e5509b1d838f71b8ef3d8892e TBR=phajdan.jr@chromium.org,alokp@chromium.org,halliwell@chromium.org,sanfin@chromium.org,xhwang@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=Internal b/37086171 Review-Url: https://codereview.chromium.org/2808943002 Cr-Commit-Position: refs/heads/master@{#463660} Committed: https://chromium.googlesource.com/chromium/src/+/9973ebb20992e56318308152e7b13e8f26fc087d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M content/test/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
AndyWu
Created Revert of Fix a linker error when building content_unittests
3 years, 8 months ago (2017-04-10 18:17:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808943002/1
3 years, 8 months ago (2017-04-10 18:17:56 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-10 18:17:58 UTC) #6
AndyWu
3 years, 8 months ago (2017-04-10 18:18:10 UTC) #7
Simeon
On 2017/04/10 18:18:10, AndyWu wrote: lgtm
3 years, 8 months ago (2017-04-10 18:21:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808943002/1
3 years, 8 months ago (2017-04-10 18:39:46 UTC) #10
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-10 18:39:47 UTC) #12
Paweł Hajdan Jr.
LGTM
3 years, 8 months ago (2017-04-11 15:40:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808943002/1
3 years, 8 months ago (2017-04-11 16:55:11 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 17:06:30 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9973ebb20992e56318308152e7b1...

Powered by Google App Engine
This is Rietveld 408576698