Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 2808923003: Revert of Enable find-in-page across GuestViews. (Closed)

Created:
3 years, 8 months ago by paulmeyer
Modified:
3 years, 8 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, extensions-reviews_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable find-in-page across GuestViews. (patchset #6 id:270001 of https://codereview.chromium.org/2700613003/ ) Reason for revert: Suspected cause of crashes: https://bugs.chromium.org/p/chromium/issues/detail?id=709478 Original issue's description: > Enable find-in-page across GuestViews. > > This patch enables find-in-page to work across GuestViews, including > WebViews and PDFs, as explained in this design doc: > https://drive.google.com/open?id=1tl1L99oTgqQxolV7jRvDLzFQ9K251rQ_E16mOwB-BuU. > Specifically, this will allow find-in-page to work with embedded PDFs, > which has been a (very) longstanding bug in Chrome. > > This patch also cleans up code that was previously used to route find > requests to the guest WebContents in the case of full-page GuestViews. > This shortcut is no longer needed, as this patch implements a more general > solution to traversing frames across all WebContentses during a find > session. > > BUG=55421 > > Review-Url: https://codereview.chromium.org/2700613003 > Cr-Commit-Position: refs/heads/master@{#462327} > Committed: https://chromium.googlesource.com/chromium/src/+/9dedb9f32fca0666761f83c405c5959c148ea751 TBR=nick@chromium.org,lfg@chromium.org,thestig@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=55421 Review-Url: https://codereview.chromium.org/2808923003 Cr-Commit-Position: refs/heads/master@{#463379} Committed: https://chromium.googlesource.com/chromium/src/+/b6c7ab52d03e896abb85e6c0a8f09d096a3ea947

Patch Set 1 #

Patch Set 2 : Fixed patch conflicts. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+299 lines, -501 lines) Patch
M chrome/browser/apps/guest_view/web_view_browsertest.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chrome_find_request_manager_browsertest.cc View 1 3 chunks +1 line, -30 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/shim/main.js View 1 4 chunks +22 lines, -61 lines 0 comments Download
M components/guest_view/browser/guest_view_base.h View 1 3 chunks +15 lines, -0 lines 0 comments Download
M components/guest_view/browser/guest_view_base.cc View 1 3 chunks +41 lines, -0 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_embedder.h View 1 2 chunks +13 lines, -0 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_embedder.cc View 1 3 chunks +46 lines, -0 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 3 chunks +12 lines, -8 lines 0 comments Download
M content/browser/find_request_manager.h View 1 5 chunks +11 lines, -15 lines 0 comments Download
M content/browser/find_request_manager.cc View 1 14 chunks +61 lines, -203 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 7 chunks +8 lines, -43 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 12 chunks +23 lines, -122 lines 0 comments Download
M content/public/browser/browser_plugin_guest_delegate.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M content/public/browser/browser_plugin_guest_delegate.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
D content/test/data/find_in_embedded_pdf_page.html View 1 chunk +0 lines, -13 lines 0 comments Download
M extensions/browser/guest_view/extension_options/extension_options_guest.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/guest_view/extension_options/extension_options_guest.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M pdf/out_of_process_instance.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
paulmeyer
Created Revert of Enable find-in-page across GuestViews.
3 years, 8 months ago (2017-04-10 18:38:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808923003/1
3 years, 8 months ago (2017-04-10 18:39:49 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/187606) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 8 months ago (2017-04-10 18:43:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808923003/260001
3 years, 8 months ago (2017-04-10 18:57:44 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 20:14:21 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:260001) as
https://chromium.googlesource.com/chromium/src/+/b6c7ab52d03e896abb85e6c0a8f0...

Powered by Google App Engine
This is Rietveld 408576698