Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Issue 2808923002: Revert of add a new set of commands to resize and position windows (patchset #35 id:680001 of https… (Closed)

Created:
3 years, 8 months ago by jzfeng
Modified:
3 years, 8 months ago
Reviewers:
samuong, dgozman, pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of add a new set of commands to resize and position windows (patchset #35 id:680001 of https://codereview.chromium.org/2734123004/ ) Reason for revert: It cause flaky browser tests on mac10.10 https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests?numbuilds=100 Original issue's description: > add a new set of commands to resize and position windows > > https://docs.google.com/document/d/1Q0kuHgU1d-sj8gePjEU9nHtlQzz5rNvvGH8fCJ3iBq4/edit?usp=sharing > > Devtools side, add a new UI domain and methods: > method: getWindowForTarget, param: targetID, return: windowID, bounds. > method: setWindowBounds, param: windowID, bounds > method: getWindowBounds, param: windowID, return: bounds > > bounds object: left, top, width, height, window_state (minimized, maximized, fullscreen, normal) > > BUG=604324 > > Review-Url: https://codereview.chromium.org/2734123004 > Cr-Commit-Position: refs/heads/master@{#463110} > Committed: https://chromium.googlesource.com/chromium/src/+/24a8ad434aab59c8c8a08ba02d934ca5fdfdc7dd TBR=dgozman@chromium.org,pfeldman@chromium.org,samuong@chromium.org Review-Url: https://codereview.chromium.org/2808923002 Cr-Commit-Position: refs/heads/master@{#463388} Committed: https://chromium.googlesource.com/chromium/src/+/da1d85c561f4c7b666dfc1ae5acb3310d9b78a20

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -522 lines) Patch
M chrome/browser/devtools/chrome_devtools_manager_delegate.h View 3 chunks +0 lines, -16 lines 0 comments Download
M chrome/browser/devtools/chrome_devtools_manager_delegate.cc View 6 chunks +3 lines, -225 lines 0 comments Download
M chrome/browser/devtools/devtools_protocol.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/devtools/devtools_protocol.cc View 2 chunks +1 line, -14 lines 0 comments Download
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 4 chunks +0 lines, -201 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/schema-get-domains-matches-agents-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/browser_protocol.json View 2 chunks +1 line, -61 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
jzfeng
3 years, 8 months ago (2017-04-10 18:05:21 UTC) #1
dgozman
lgtm
3 years, 8 months ago (2017-04-10 18:16:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808923002/1
3 years, 8 months ago (2017-04-10 18:19:02 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 20:56:11 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/da1d85c561f4c7b666dfc1ae5acb...

Powered by Google App Engine
This is Rietveld 408576698