Fix ASAN component builds by adding proper dependencies to executable targets.

Fix ASAN component builds by adding proper dependencies to executable targets.

Before this CL, building |gn_all| ninja target fails with linking errors
similar to:

../../buildtools/third_party/libc++/trunk/include/string:2027: error: undefined reference to 'std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::__init(char const*, unsigned long)'

After this CL |gn_all| builds find in with the following args.gn:

    dcheck_always_on = true
    is_asan = true
    is_component_build = true
    is_debug = false
    use_goma = true
    enable_nacl = false

This CL is sort of a a follow up to
https://groups.google.com/a/chromium.org/forum/#!searchin/gn-dev/asan/gn-dev/PTcQk8c9vXE/rfU-nAArBQAJ

BUG=

Review-Url: https://codereview.chromium.org/2808863003
Cr-Commit-Position: refs/heads/master@{#464747}
Committed: https://chromium.googlesource.com/chromium/src/+/5b312d91217af1f30eebece283a2cbf75effa076

[Łukasz Anforowicz, 2017-04-10 17:31:59]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 17:32:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2017-04-10 17:33:13]

lukasza@chromium.org changed reviewers:
+ brettw@chromium.org

[Łukasz Anforowicz, 2017-04-10 17:33:13]

brettw@, could you PTAL?

I am not sure if there is a bug I should associate this CL with.  All I found in
the archives was a thread on gn-dev here:
https://groups.google.com/a/chromium.org/d/msg/gn-dev/PTcQk8c9vXE/Cc332LkqAAAJ

[commit-bot: I haz the power, 2017-04-10 19:14:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 19:14:55]

Dry run: This issue passed the CQ dry run.

[brettw, 2017-04-11 22:19:04]

lgtm

[Łukasz Anforowicz, 2017-04-11 22:27:41]

lukasza@chromium.org changed reviewers:
+ rockot@chromium.org, rsleevi@chromium.org, scheib@chromium.org,
sergeyu@chromium.org, zhenw@chromium.org

[Łukasz Anforowicz, 2017-04-11 22:27:41]

+scheib@ for content/browser/bluetooth
+rsleevi@ for net/tools (and +martijn@martijnc.be to CC as FYI)
+sergeyu@ for remoting (and +rkjnsn@ to CC as FYI)
+rockot@ for services/service_manager
+zhenw@ for tools/battor_agent (since charliea@ is OOO for a while)

[Ken Rockot(use gerrit already), 2017-04-11 22:28:21]

lgtm

[Ryan Sleevi, 2017-04-11 22:36:51]

I'm rubber-stamping, because I defer entirely to Brett there. It feels weird to
add that dependency to tools, and I don't understand it, but if Brett's
confident this is the best path, then I support it :)

[scheib, 2017-04-11 23:08:51]

I'm not going to hold this up, so lgtm. But, I do wonder if this implies that
all new executables would need this dep? Should we add it to e.g.
set_defaults("executable")?
https://cs.chromium.org/search/?q=f:src/build+f:gn+set_defaults%5C(%22executa...

[Łukasz Anforowicz, 2017-04-11 23:18:23]

rsleevi@ / scheib@ - the idea of setting the dependencies in a centralized place
was discussed in
https://groups.google.com/a/chromium.org/forum/#!msg/gn-dev/PTcQk8c9vXE/Cc332...
and tentatively rejected, because it would require changing |deps = ...| into
|deps += ...| for all executables, at the same time (so would be difficult for
DEPS-ed in third-party code).  Maybe it is worth looking into this again?  Do
you want to ping that gn-dev thread?

[scheib, 2017-04-12 01:04:51]

On 2017/04/11 23:18:23, Łukasz A. wrote:
> rsleevi@ / scheib@ - the idea of setting the dependencies in a centralized
place
> was discussed in
>
https://groups.google.com/a/chromium.org/forum/#!msg/gn-dev/PTcQk8c9vXE/Cc332...
> and tentatively rejected, because it would require changing |deps = ...| into
> |deps += ...| for all executables, at the same time (so would be difficult for
> DEPS-ed in third-party code).  Maybe it is worth looking into this again?  Do
> you want to ping that gn-dev thread?

Good to know the discussion happened- and those folks are the ones who should
make this call.

[Ryan Sleevi, 2017-04-12 02:24:15]

On 2017/04/12 01:04:51, scheib wrote:
> Good to know the discussion happened- and those folks are the ones who should
> make this call.

+1 thanks for the context :)

[Zhen Wang, 2017-04-13 00:04:49]

zhenw@chromium.org changed reviewers:
+ nednguyen@google.com

[Zhen Wang, 2017-04-13 00:04:50]

lgtm

Adding nednguyen and ccing charliea (currently OOO), who are more active owners
in //tools/battor_agent. They should be aware of this dep.

[Sergey Ulanov, 2017-04-13 01:07:24]

lgtm

[Ryan Sleevi, 2017-04-13 16:53:02]

lgtm

[Łukasz Anforowicz, 2017-04-14 13:59:38]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2017-04-14 13:59:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 17:43:36]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492178378869930, "parent_rev":
"1cabd22b2e8ee5e4ff1fd679bbb73c0b2542d405", "commit_rev":
"5b312d91217af1f30eebece283a2cbf75effa076"}

[commit-bot: I haz the power, 2017-04-14 17:44:27]

Description was changed from

==========
Fix ASAN component builds by adding proper dependencies to executable targets.

Before this CL, building |gn_all| ninja target fails with linking errors
similar to:

../../buildtools/third_party/libc++/trunk/include/string:2027: error: undefined
reference to 'std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char> >::__init(char const*, unsigned long)'

After this CL |gn_all| builds find in with the following args.gn:

    dcheck_always_on = true
    is_asan = true
    is_component_build = true
    is_debug = false
    use_goma = true
    enable_nacl = false

This CL is sort of a a follow up to
https://groups.google.com/a/chromium.org/forum/#!searchin/gn-dev/asan/gn-dev/...

BUG=
==========

to

==========
Fix ASAN component builds by adding proper dependencies to executable targets.

Before this CL, building |gn_all| ninja target fails with linking errors
similar to:

../../buildtools/third_party/libc++/trunk/include/string:2027: error: undefined
reference to 'std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char> >::__init(char const*, unsigned long)'

After this CL |gn_all| builds find in with the following args.gn:

    dcheck_always_on = true
    is_asan = true
    is_component_build = true
    is_debug = false
    use_goma = true
    enable_nacl = false

This CL is sort of a a follow up to
https://groups.google.com/a/chromium.org/forum/#!searchin/gn-dev/asan/gn-dev/...

BUG=

Review-Url: https://codereview.chromium.org/2808863003
Cr-Commit-Position: refs/heads/master@{#464747}
Committed:
https://chromium.googlesource.com/chromium/src/+/5b312d91217af1f30eebece283a2...
==========

[commit-bot: I haz the power, 2017-04-14 17:44:28]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5b312d91217af1f30eebece283a2...