Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2808863002: [LayoutNG] Use NGLogicalSize in NGBlockLayoutAlgorithm (Closed)

Created:
3 years, 8 months ago by eae
Modified:
3 years, 8 months ago
Reviewers:
cbiesinger, Gleb Lanbin
CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Use NGLogicalSize in NGBlockLayoutAlgorithm Try to simplify coordinate handling in NGBlockLayoutAlgorithm::Layout by using NGLogicalSize instead of raw LayoutUnits for the block/inline dir. R=glebl@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng Review-Url: https://codereview.chromium.org/2808863002 Cr-Commit-Position: refs/heads/master@{#463354} Committed: https://chromium.googlesource.com/chromium/src/+/f768bcf3d097e89d75c394e9e39e3139f87348fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -22 lines) Patch
M third_party/WebKit/Source/core/layout/ng/geometry/ng_logical_size.h View 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 2 chunks +19 lines, -22 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
eae
When merged with https://codereview.chromium.org/2807113002/ it is further simplified as that allows the full size to ...
3 years, 8 months ago (2017-04-10 14:53:06 UTC) #2
Gleb Lanbin
lgtm
3 years, 8 months ago (2017-04-10 16:31:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808863002/1
3 years, 8 months ago (2017-04-10 18:58:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/f768bcf3d097e89d75c394e9e39e3139f87348fe
3 years, 8 months ago (2017-04-10 19:19:30 UTC) #12
cbiesinger
3 years, 8 months ago (2017-04-10 20:59:37 UTC) #13
Message was sent while issue was closed.
thanks for this change! lgtm

Powered by Google App Engine
This is Rietveld 408576698