Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 2808853003: Remove Blink copies of readable-streams layout tests (Closed)

Created:
3 years, 8 months ago by Adam Rice
Modified:
3 years, 8 months ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Blink copies of readable-streams layout tests web-platform-tests for ReadableStream are imported from upstream, so remove our local copies. writable-streams and piping tests are not removed in this CL, as the CLs https://codereview.chromium.org/2772293002/ and https://codereview.chromium.org/2796633002/ will delete them. Issue 705125 is referenced because two of the deleted tests were included in TextExpectations as having non-deterministic results. BUG=705125 Review-Url: https://codereview.chromium.org/2808853003 Cr-Commit-Position: refs/heads/master@{#464317} Committed: https://chromium.googlesource.com/chromium/src/+/ba36ef765de08362765f726520fbe52db23faf25

Patch Set 1 #

Patch Set 2 : Restore rs-utils.js as it is used by fetch tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4587 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/byte-length-queuing-strategy.html View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/byte-length-queuing-strategy.js View 1 chunk +0 lines, -107 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/byte-length-queuing-strategy-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/count-queuing-strategy.html View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/count-queuing-strategy.js View 1 chunk +0 lines, -106 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/count-queuing-strategy-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/readable-streams/bad-strategies.html View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/readable-streams/bad-strategies.js View 1 chunk +0 lines, -175 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/readable-streams/bad-strategies-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/readable-streams/bad-underlying-sources.html View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/readable-streams/bad-underlying-sources.js View 1 chunk +0 lines, -383 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/readable-streams/bad-underlying-sources-expected.txt View 1 chunk +0 lines, -89 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/readable-streams/brand-checks.html View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/readable-streams/brand-checks.js View 1 chunk +0 lines, -151 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/readable-streams/brand-checks-expected.txt View 1 chunk +0 lines, -65 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/readable-streams/cancel.html View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/readable-streams/cancel.js View 1 chunk +0 lines, -241 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/readable-streams/count-queuing-strategy-integration.html View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/readable-streams/count-queuing-strategy-integration.js View 1 chunk +0 lines, -213 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/readable-streams/count-queuing-strategy-integration-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/readable-streams/garbage-collection.html View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/readable-streams/garbage-collection.js View 1 chunk +0 lines, -75 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/readable-streams/garbage-collection-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/readable-streams/general.html View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/readable-streams/general.js View 1 chunk +0 lines, -853 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/readable-streams/general-expected.txt View 1 chunk +0 lines, -145 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/readable-streams/readable-stream-reader.html View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/readable-streams/readable-stream-reader.js View 1 chunk +0 lines, -485 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/readable-streams/readable-stream-reader-expected.txt View 1 chunk +0 lines, -109 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/readable-streams/tee.html View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/readable-streams/tee.js View 1 chunk +0 lines, -254 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/readable-streams/tee-expected.txt View 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/readable-streams/templated.html View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/readable-streams/templated.js View 1 chunk +0 lines, -148 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/streams/resources/rs-test-templates.js View 1 chunk +0 lines, -632 lines 0 comments Download

Messages

Total messages: 25 (15 generated)
Adam Rice
3 years, 8 months ago (2017-04-11 13:32:17 UTC) #10
domenic
On 2017/04/11 at 13:32:17, ricea wrote: > lgtm. Do we have a bug filed on ...
3 years, 8 months ago (2017-04-11 16:51:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808853003/20001
3 years, 8 months ago (2017-04-12 02:34:29 UTC) #13
Adam Rice
On 2017/04/11 16:51:54, domenic wrote: > lgtm. Do we have a bug filed on driving ...
3 years, 8 months ago (2017-04-12 02:34:33 UTC) #15
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-12 02:34:34 UTC) #16
Adam Rice
+tyoshino please rubberstamp this.
3 years, 8 months ago (2017-04-12 03:53:15 UTC) #17
Adam Rice
It would have worked better if I'd actually added tyoshino@. +tyoshino again.
3 years, 8 months ago (2017-04-13 03:41:50 UTC) #19
tyoshino (SeeGerritForStatus)
lgtm I see readable-stream-reader.js is now default-reader.js.
3 years, 8 months ago (2017-04-13 04:44:10 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808853003/20001
3 years, 8 months ago (2017-04-13 04:46:06 UTC) #22
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 06:21:03 UTC) #25
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ba36ef765de08362765f726520fb...

Powered by Google App Engine
This is Rietveld 408576698