Add operator<<(ostream, AlternativeService) for test output formatting.

Add operator<<(ostream, AlternativeService) for test output formatting.

The advantage is that if a test expectation like
EXPECT_EQ(alternative_service1, alternative_service2) fails in any test
in any file, then pretty printed contents of both alternative service
structs will be displayed.

The disadvantage is that this helper function is now in production code.
Note that the same approach is already used with a number of formatting
helper methods, for example, for SpdySettingsIds, SpdyFrameType,
Http2FrameType etc.

Repeating PrintTo() definition in every unittest.cc does not work: it
causes a namespace collision.  Moving it into anonymous namespace does
not work: gTest would not find it there, and it indeed fails with unused
function error.  There is no obvious place for this function:
//net/http/http_test_utils.h does not exist,
//net/spdy/spdy_test_utils.h or //net/quic/test_tools/quic_test_utils.h
is not quite the right place.

Review-Url: https://codereview.chromium.org/2808843002
Cr-Commit-Position: refs/heads/master@{#463290}
Committed: https://chromium.googlesource.com/chromium/src/+/396d33b1f92f90f9cdecd880748bf489954691e7

[Bence, 2017-04-10 13:35:58]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 13:36:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bence, 2017-04-10 13:37:53]

bnc@chromium.org changed reviewers:
+ rch@chromium.org

[Bence, 2017-04-10 13:37:53]

Ryan: PTAL.  Thank you.

[Ryan Hamilton, 2017-04-10 13:45:35]

lgtm

[commit-bot: I haz the power, 2017-04-10 15:09:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 15:09:57]

Dry run: This issue passed the CQ dry run.

[Bence, 2017-04-10 16:33:48]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2017-04-10 16:34:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 16:40:26]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491842028447910, "parent_rev":
"de94e722f95b295b6150013fb8e42f1891078c3a", "commit_rev":
"396d33b1f92f90f9cdecd880748bf489954691e7"}

[commit-bot: I haz the power, 2017-04-10 16:41:31]

Description was changed from

==========
Add operator<<(ostream, AlternativeService) for test output formatting.

The advantage is that if a test expectation like
EXPECT_EQ(alternative_service1, alternative_service2) fails in any test
in any file, then pretty printed contents of both alternative service
structs will be displayed.

The disadvantage is that this helper function is now in production code.
Note that the same approach is already used with a number of formatting
helper methods, for example, for SpdySettingsIds, SpdyFrameType,
Http2FrameType etc.

Repeating PrintTo() definition in every unittest.cc does not work: it
causes a namespace collision.  Moving it into anonymous namespace does
not work: gTest would not find it there, and it indeed fails with unused
function error.  There is no obvious place for this function:
//net/http/http_test_utils.h does not exist,
//net/spdy/spdy_test_utils.h or //net/quic/test_tools/quic_test_utils.h
is not quite the right place.
==========

to

==========
Add operator<<(ostream, AlternativeService) for test output formatting.

The advantage is that if a test expectation like
EXPECT_EQ(alternative_service1, alternative_service2) fails in any test
in any file, then pretty printed contents of both alternative service
structs will be displayed.

The disadvantage is that this helper function is now in production code.
Note that the same approach is already used with a number of formatting
helper methods, for example, for SpdySettingsIds, SpdyFrameType,
Http2FrameType etc.

Repeating PrintTo() definition in every unittest.cc does not work: it
causes a namespace collision.  Moving it into anonymous namespace does
not work: gTest would not find it there, and it indeed fails with unused
function error.  There is no obvious place for this function:
//net/http/http_test_utils.h does not exist,
//net/spdy/spdy_test_utils.h or //net/quic/test_tools/quic_test_utils.h
is not quite the right place.

Review-Url: https://codereview.chromium.org/2808843002
Cr-Commit-Position: refs/heads/master@{#463290}
Committed:
https://chromium.googlesource.com/chromium/src/+/396d33b1f92f90f9cdecd880748b...
==========

[commit-bot: I haz the power, 2017-04-10 16:41:32]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/396d33b1f92f90f9cdecd880748b...