Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 2808833003: Stop running deprecated simulation_test (Closed)

Created:
3 years, 8 months ago by Paweł Hajdan Jr.
Modified:
3 years, 8 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Stop running deprecated simulation_test This is also needed for https://codereview.chromium.org/2806373004/ which fails under simulation_test (and flakes, especially locally: sometimes passes, and coverage results differ between runs). It passes reliably with the new 'test' command. BUG=chromium:699120, chromium:693058 Review-Url: https://codereview.chromium.org/2808833003 Committed: https://github.com/luci/recipes-py/commit/56ba34248d8319cfdaff19ae55d68004fdd8ebf8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M unittests/stdlib_test.py View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (8 generated)
iannucci
lgtm and feel free to do the same in other repos
3 years, 8 months ago (2017-04-10 20:32:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808833003/1
3 years, 8 months ago (2017-04-10 20:54:16 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 20:58:14 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/recipes-py/commit/56ba34248d8319cfdaff19ae55d68004fdd...

Powered by Google App Engine
This is Rietveld 408576698