MacViews: Allows the toolkit-views Manage Passwords Dialog to be used

chrome/test/base/in_process_browser_test.h

Index: chrome/test/base/in_process_browser_test.h
diff --git a/chrome/test/base/in_process_browser_test.h b/chrome/test/base/in_process_browser_test.h
index d7bb9d152f7f18488643d68fefbd73aca6c54be6..da9f8a0be3e35e04cd5ecbb9009f1f9b3271cf31 100644
--- a/chrome/test/base/in_process_browser_test.h
+++ b/chrome/test/base/in_process_browser_test.h
@@ -18,6 +18,14 @@
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/page_transition_types.h"
 
+#if defined(OS_MACOSX)
+namespace ui {

[tapted, 2017/04/19 03:31:07]

nit: sort namespaces ("ui" after "base")

edit: actually, I would just #include
"ui/base/test/scoped_fake_full_keyboard_access.h" between the #ifdef guards and
not use a scoped_ptr -- style guide says ~"don't forward declare/unique_ptr just
to avoid an #include"

Then we don't need to change /in_process_browser_test.cc at all

[varkha, 2017/04/19 08:34:17]

Done.

+namespace test {
+class ScopedFakeFullKeyboardAccess;
+}  // namespace test
+}  // namespace ui
+#endif  // defined(OS_MACOSX)
+
 namespace base {
 
 class CommandLine;
@@ -264,6 +272,13 @@ class InProcessBrowserTest : public content::BrowserTestBase {
 #if defined(OS_MACOSX)
   base::mac::ScopedNSAutoreleasePool* autorelease_pool_;
   std::unique_ptr<ScopedBundleSwizzlerMac> bundle_swizzler_;
+
+  // Enable fake full keyboard access by default, so that tests don't depend on
+  // system setting of the test machine. Also, this helps to make tests on Mac
+  // more consistent with other platforms, where most views are focusable by
+  // default.
+  std::unique_ptr<ui::test::ScopedFakeFullKeyboardAccess>
+      faked_full_keyboard_access_;
 #endif  // OS_MACOSX
 
 #if defined(OS_WIN)