MacViews: Allows the toolkit-views Manage Passwords Dialog to be used

chrome/test/base/in_process_browser_test.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_TEST_BASE_IN_PROCESS_BROWSER_TEST_H_
 #define CHROME_TEST_BASE_IN_PROCESS_BROWSER_TEST_H_
 
 #include <memory>
 
 #include "base/compiler_specific.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/memory/ref_counted.h"
 #include "build/build_config.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/test/browser_test.h"
 #include "content/public/test/browser_test_base.h"
 #include "storage/browser/quota/quota_settings.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/page_transition_types.h"
 
+#if defined(OS_MACOSX)
+namespace ui {

[tapted, 2017/04/19 03:31:07]

nit: sort namespaces ("ui" after "base")

edit: actually, I would just #include
"ui/base/test/scoped_fake_full_keyboard_access.h" between the #ifdef guards and
not use a scoped_ptr -- style guide says ~"don't forward declare/unique_ptr just
to avoid an #include"

Then we don't need to change /in_process_browser_test.cc at all

[varkha, 2017/04/19 08:34:17]

Done.

+namespace test {
+class ScopedFakeFullKeyboardAccess;
+}  // namespace test
+}  // namespace ui
+#endif  // defined(OS_MACOSX)
+
 namespace base {
 
 class CommandLine;
 
 #if defined(OS_MACOSX)
 namespace mac {
 class ScopedNSAutoreleasePool;
 }  // namespace mac
 #endif  // defined(OS_MACOSX)
 
@@ skipping 226 matching lines @@
   // True if the accessibility test should run for a particular test case.
   // This is reset for every test case.
   bool run_accessibility_checks_for_test_case_;
 
   // We use hardcoded quota settings to have a consistent testing environment.
   storage::QuotaSettings quota_settings_;
 
 #if defined(OS_MACOSX)
   base::mac::ScopedNSAutoreleasePool* autorelease_pool_;
   std::unique_ptr<ScopedBundleSwizzlerMac> bundle_swizzler_;
+
+  // Enable fake full keyboard access by default, so that tests don't depend on
+  // system setting of the test machine. Also, this helps to make tests on Mac
+  // more consistent with other platforms, where most views are focusable by
+  // default.
+  std::unique_ptr<ui::test::ScopedFakeFullKeyboardAccess>
+      faked_full_keyboard_access_;
 #endif  // OS_MACOSX
 
 #if defined(OS_WIN)
   std::unique_ptr<base::win::ScopedCOMInitializer> com_initializer_;
 #endif
 };
 
 #endif  // CHROME_TEST_BASE_IN_PROCESS_BROWSER_TEST_H_