MacViews: Allows the toolkit-views Manage Passwords Dialog to be used

chrome/browser/ui/cocoa/tab_dialogs_cocoa.mm

Index: chrome/browser/ui/cocoa/tab_dialogs_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/tab_dialogs_cocoa.mm b/chrome/browser/ui/cocoa/tab_dialogs_cocoa.mm
index a66b2ee678c91e88d4eb4e92e9924821a395c60e..cd2cf18e6a9dea9ff7581e83c4e1a83cdd5981a9 100644
--- a/chrome/browser/ui/cocoa/tab_dialogs_cocoa.mm
+++ b/chrome/browser/ui/cocoa/tab_dialogs_cocoa.mm
@@ -75,7 +75,9 @@ void TabDialogsCocoa::ShowManagePasswordsBubble(bool user_action) {
 }
 
 void TabDialogsCocoa::HideManagePasswordsBubble() {
-  // The bubble is closed when it loses the focus.
+  // Close toolkit-views bubble.
+  // In Cocoa code path the bubble is closed when it loses the focus.
+  ManagePasswordsBubbleCocoa::CloseCurrentBubble();

[tapted, 2017/04/19 03:31:06]

I think we can call ManagePasswordsBubbleView::CloseCurrentBubble() directly in
tab_dialogs_views_mac.mm - then we don't need
ManagePasswordsBubbleCocoa::CloseCurrentBubble() or
CloseViewsManagePasswordsBubbleOnCocoaBrowser()

[varkha, 2017/04/19 08:34:16]

Done (and same for the ShowManagePasswordsBubble - moved the implementation to
tab_dialogs_views_mac.mm as well.

 }
 
 base::WeakPtr<ValidationMessageBubble> TabDialogsCocoa::ShowValidationMessage(