MacViews: Allows the toolkit-views Manage Passwords Dialog to be used

chrome/browser/ui/cocoa/tab_dialogs_cocoa.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/tab_dialogs_cocoa.h"
 
 #include "base/memory/ptr_util.h"
 #import "chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.h"
 #import "chrome/browser/ui/cocoa/hung_renderer_controller.h"
 #import "chrome/browser/ui/cocoa/passwords/passwords_bubble_cocoa.h"
@@ skipping 57 matching lines @@
     std::unique_ptr<ui::ProfileSigninConfirmationDelegate> delegate) {
   ProfileSigninConfirmationDialogCocoa::Show(browser, web_contents_, profile,
                                              username, std::move(delegate));
 }
 
 void TabDialogsCocoa::ShowManagePasswordsBubble(bool user_action) {
   ManagePasswordsBubbleCocoa::Show(web_contents_, user_action);
 }
 
 void TabDialogsCocoa::HideManagePasswordsBubble() {
-  // The bubble is closed when it loses the focus.
+  // Close toolkit-views bubble.
+  // In Cocoa code path the bubble is closed when it loses the focus.
+  ManagePasswordsBubbleCocoa::CloseCurrentBubble();

[tapted, 2017/04/19 03:31:06]

I think we can call ManagePasswordsBubbleView::CloseCurrentBubble() directly in
tab_dialogs_views_mac.mm - then we don't need
ManagePasswordsBubbleCocoa::CloseCurrentBubble() or
CloseViewsManagePasswordsBubbleOnCocoaBrowser()

[varkha, 2017/04/19 08:34:16]

Done (and same for the ShowManagePasswordsBubble - moved the implementation to
tab_dialogs_views_mac.mm as well.

 }
 
 base::WeakPtr<ValidationMessageBubble> TabDialogsCocoa::ShowValidationMessage(
     const gfx::Rect& anchor_in_root_view,
     const base::string16& main_text,
     const base::string16& sub_text) {
   return (new ValidationMessageBubbleCocoa(
       web_contents_, anchor_in_root_view, main_text, sub_text))->AsWeakPtr();
 }