MacViews: Allows the toolkit-views Manage Passwords Dialog to be used

chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h

Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h
diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h
index 170b63424089b189dac82647269cb402e80306af..081f8ffac0df9247f640f1f3e8c4baef79796b9f 100644
--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h
+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h
@@ -35,11 +35,19 @@ class ManagePasswordsBubbleView : public LocationBarBubbleDelegateView {
   // Makes the bubble the foreground window.
   static void ActivateBubble();
 
+  // Returns true if a bubble is currently shown.
+  static bool IsBubbleShown();

[tapted, 2017/04/12 05:08:42]

nit: maybe `IsBubbleShowing()` (`shown` may imply it has been shown at least
once)

edit: Or in fact maybe we do not need this at all, since there is already a
public accessor for manage_password_bubble() - we check whether it is null. See
also

bool IsBubbleShowing() {
  return ManagePasswordsBubbleView::manage_password_bubble() &&
      ManagePasswordsBubbleView::manage_password_bubble()->
          GetWidget()->IsVisible();
}

in manage_passwords_bubble_view_interactive_uitest.cc

[varkha, 2017/04/12 09:16:43]

Done.

+
   // Returns a pointer to the bubble.
   static ManagePasswordsBubbleView* manage_password_bubble() {
     return manage_passwords_bubble_;
   }
 
+  ManagePasswordsBubbleView(content::WebContents* web_contents,
+                            views::View* anchor_view,
+                            const gfx::Point& anchor_point,
+                            DisplayReason reason);
+
   content::WebContents* web_contents() const;
 
 #if defined(UNIT_TEST)
@@ -62,9 +70,6 @@ class ManagePasswordsBubbleView : public LocationBarBubbleDelegateView {
   class SignInPromoView;
   class UpdatePendingView;
 
-  ManagePasswordsBubbleView(content::WebContents* web_contents,
-                            views::View* anchor_view,
-                            DisplayReason reason);
   ~ManagePasswordsBubbleView() override;
 
   // LocationBarBubbleDelegateView: