MacViews: Allows the toolkit-views Manage Passwords Dialog to be used

chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_VIEW_H_
 
 #include "base/macros.h"
 #include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h"
 #include "chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h"
@@ skipping 17 matching lines @@
   // Shows the bubble.
   static void ShowBubble(content::WebContents* web_contents,
                          DisplayReason reason);
 
   // Closes the existing bubble.
   static void CloseCurrentBubble();
 
   // Makes the bubble the foreground window.
   static void ActivateBubble();
 
+  // Returns true if a bubble is currently shown.
+  static bool IsBubbleShown();

[tapted, 2017/04/12 05:08:42]

nit: maybe `IsBubbleShowing()` (`shown` may imply it has been shown at least
once)

edit: Or in fact maybe we do not need this at all, since there is already a
public accessor for manage_password_bubble() - we check whether it is null. See
also

bool IsBubbleShowing() {
  return ManagePasswordsBubbleView::manage_password_bubble() &&
      ManagePasswordsBubbleView::manage_password_bubble()->
          GetWidget()->IsVisible();
}

in manage_passwords_bubble_view_interactive_uitest.cc

[varkha, 2017/04/12 09:16:43]

Done.

+
   // Returns a pointer to the bubble.
   static ManagePasswordsBubbleView* manage_password_bubble() {
     return manage_passwords_bubble_;
   }
 
+  ManagePasswordsBubbleView(content::WebContents* web_contents,
+                            views::View* anchor_view,
+                            const gfx::Point& anchor_point,
+                            DisplayReason reason);
+
   content::WebContents* web_contents() const;
 
 #if defined(UNIT_TEST)
   const View* initially_focused_view() const {
     return initially_focused_view_;
   }
 
   static void set_auto_signin_toast_timeout(int seconds) {
     auto_signin_toast_timeout_ = seconds;
   }
 #endif
 
   ManagePasswordsBubbleModel* model() { return &model_; }
 
  private:
   class AutoSigninView;
   class ManageView;
   class PendingView;
   class SaveConfirmationView;
   class SignInPromoView;
   class UpdatePendingView;
 
-  ManagePasswordsBubbleView(content::WebContents* web_contents,
-                            views::View* anchor_view,
-                            DisplayReason reason);
   ~ManagePasswordsBubbleView() override;
 
   // LocationBarBubbleDelegateView:
   views::View* GetInitiallyFocusedView() override;
   void Init() override;
   void CloseBubble() override;
 
   // WidgetDelegate:
   base::string16 GetWindowTitle() const override;
   gfx::ImageSkia GetWindowIcon() override;
@@ skipping 24 matching lines @@
   ManagePasswordsBubbleModel model_;
 
   views::View* initially_focused_view_;
 
   std::unique_ptr<WebContentMouseHandler> mouse_handler_;
 
   DISALLOW_COPY_AND_ASSIGN(ManagePasswordsBubbleView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_VIEW_H_