MacViews: Allows the toolkit-views Manage Passwords Dialog to be used

chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h

Index: chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h
diff --git a/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h b/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h
index c83cd4314e09be680995ac25bf090640ef2e58f3..6f0f9f474915cc2b1dbfe498ecef731147e6ddb7 100644
--- a/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h
+++ b/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h
@@ -35,6 +35,10 @@ class LocationBarBubbleDelegateView : public views::BubbleDialogDelegateView,
   };
 
   LocationBarBubbleDelegateView(views::View* anchor_view,
+                                const gfx::Point& anchor_point,
+                                views::BubbleBorder::Arrow arrow,

[tapted, 2017/04/12 05:08:42]

Can we remove the |arrow| argument by calling

bubble_view->set_arrow(views::BubbleBorder::TOP_RIGHT) in
ShowViewsManagePasswordsBubbleOnCocoaBrowser? E.g. immediately before/after it
sets the parent window.

But also, we may actually want to set the anchor to NONE in some cases on Mac.
E.g if there's a password request in a popup window (window.open()) there may be
no location bar/icon. I think other platforms will center the dialog below the
titlebar in that case

[varkha, 2017/04/12 09:16:43]

Done. And we don't center it on other platforms (where the bubble shows
right-top-aligned in the window. We would do the same here when
http://crbug.com/710694 is resolved.

+                                content::WebContents* web_contents);
+  LocationBarBubbleDelegateView(views::View* anchor_view,
                                 content::WebContents* web_contents);
   ~LocationBarBubbleDelegateView() override;
 
@@ -71,6 +75,13 @@ class LocationBarBubbleDelegateView : public views::BubbleDialogDelegateView,
     DISALLOW_COPY_AND_ASSIGN(WebContentMouseHandler);
   };
 
+  // Sets up the bubble anchoring to |anchor_view|.
+  // Uses |anchor_point| and |arrow| type when |anchor_view| is nullptr.
+  void SetupAnchor(views::View* anchor_view,
+                   const gfx::Point& anchor_point,
+                   views::BubbleBorder::Arrow arrow,
+                   content::WebContents* web_contents);
+
   // Closes the bubble.
   virtual void CloseBubble();