MacViews: Allows the toolkit-views Manage Passwords Dialog to be used

chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_BUBBLE_DELEGATE_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_BUBBLE_DELEGATE_VIEW_H_
 
 #include "base/macros.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
@@ skipping 17 matching lines @@
     // location bar icon).
     USER_GESTURE,
 
     // The bubble appears spontaneously over the course of the user's
     // interaction with Chrome (e.g. due to some change in the feature's
     // status).
     AUTOMATIC,
   };
 
   LocationBarBubbleDelegateView(views::View* anchor_view,
+                                const gfx::Point& anchor_point,
+                                views::BubbleBorder::Arrow arrow,

[tapted, 2017/04/12 05:08:42]

Can we remove the |arrow| argument by calling

bubble_view->set_arrow(views::BubbleBorder::TOP_RIGHT) in
ShowViewsManagePasswordsBubbleOnCocoaBrowser? E.g. immediately before/after it
sets the parent window.

But also, we may actually want to set the anchor to NONE in some cases on Mac.
E.g if there's a password request in a popup window (window.open()) there may be
no location bar/icon. I think other platforms will center the dialog below the
titlebar in that case

[varkha, 2017/04/12 09:16:43]

Done. And we don't center it on other platforms (where the bubble shows
right-top-aligned in the window. We would do the same here when
http://crbug.com/710694 is resolved.

+                                content::WebContents* web_contents);
+  LocationBarBubbleDelegateView(views::View* anchor_view,
                                 content::WebContents* web_contents);
   ~LocationBarBubbleDelegateView() override;
 
   // Displays the bubble with appearance and behavior tailored for |reason|.
   void ShowForReason(DisplayReason reason);
 
   // views::BubbleDialogDelegateView:
   int GetDialogButtons() const override;
 
   // content::NotificationObserver:
@@ skipping 16 matching lines @@
     void OnTouchEvent(ui::TouchEvent* event) override;
 
    private:
     LocationBarBubbleDelegateView* bubble_;
     content::WebContents* web_contents_;
     std::unique_ptr<views::EventMonitor> event_monitor_;
 
     DISALLOW_COPY_AND_ASSIGN(WebContentMouseHandler);
   };
 
+  // Sets up the bubble anchoring to |anchor_view|.
+  // Uses |anchor_point| and |arrow| type when |anchor_view| is nullptr.
+  void SetupAnchor(views::View* anchor_view,
+                   const gfx::Point& anchor_point,
+                   views::BubbleBorder::Arrow arrow,
+                   content::WebContents* web_contents);
+
   // Closes the bubble.
   virtual void CloseBubble();
 
   // If the bubble is not anchored to a view, places the bubble in the top right
   // (left in RTL) of the |screen_bounds| that contain web contents's browser
   // window. Because the positioning is based on the size of the bubble, this
   // must be called after the bubble is created.
   void AdjustForFullscreen(const gfx::Rect& screen_bounds);
 
  private:
   // Used to register for fullscreen change notifications.
   content::NotificationRegistrar registrar_;
 
   DISALLOW_COPY_AND_ASSIGN(LocationBarBubbleDelegateView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_BUBBLE_DELEGATE_VIEW_H_