Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2808813002: Update gdb and lldb webkit macros after blink rename (Closed)

Created:
3 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
3 years, 8 months ago
Reviewers:
Dirk Pranke, Nico, dcheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -57 lines) Patch
M third_party/WebKit/Tools/gdb/webkit.py View 12 chunks +30 lines, -25 lines 0 comments Download
M third_party/WebKit/Tools/lldb/lldb_webkit.py View 10 chunks +32 lines, -32 lines 1 comment Download

Messages

Total messages: 14 (7 generated)
jochen (gone - plz use gerrit)
3 years, 8 months ago (2017-04-10 11:46:49 UTC) #1
jochen (gone - plz use gerrit)
dcheng, ptal (dpranke, owners approval) https://codereview.chromium.org/2808813002/diff/1/third_party/WebKit/Tools/lldb/lldb_webkit.py File third_party/WebKit/Tools/lldb/lldb_webkit.py (right): https://codereview.chromium.org/2808813002/diff/1/third_party/WebKit/Tools/lldb/lldb_webkit.py#newcode141 third_party/WebKit/Tools/lldb/lldb_webkit.py:141: # FIXME: This should ...
3 years, 8 months ago (2017-04-10 11:47:33 UTC) #4
Dirk Pranke
lgtm whenever the others are happy with it.
3 years, 8 months ago (2017-04-10 17:30:07 UTC) #7
dcheng
LGTM, thanks for fixing this (I didn't even know about these)
3 years, 8 months ago (2017-04-10 17:37:46 UTC) #8
jochen (gone - plz use gerrit)
landing as is, happy to update the llvm part later... m_data{8,16} doesn't exist anymore for ...
3 years, 8 months ago (2017-04-10 19:00:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808813002/1
3 years, 8 months ago (2017-04-10 19:01:33 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 19:14:04 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/67f5982276daedc4bcfe25fbc21d...

Powered by Google App Engine
This is Rietveld 408576698