[regexp] implement \p{Other_ID_Start} and \p{Other_ID_Continue}.

[regexp] implement \p{Other_ID_Start} and \p{Other_ID_Continue}.

Other_ID_Start and Other_ID_Continue are not supported by ICU, so for
now we implement these manually as special binary property classes.

R=jgruber@chromium.org
BUG=v8:4743
Review-Url: https://codereview.chromium.org/2808803002
Cr-Commit-Position: refs/heads/master@{#44549}
Committed: https://chromium.googlesource.com/v8/v8/+/26e5d0129ca501e4dbadaa098e65222687ce4ab0

[jgruber, 2017-04-10 13:46:50]

lgtm

https://codereview.chromium.org/2808803002/diff/20001/test/mjsunit/harmony/re...
File test/mjsunit/harmony/regexp-property-special.js (right):

https://codereview.chromium.org/2808803002/diff/20001/test/mjsunit/harmony/re...
test/mjsunit/harmony/regexp-property-special.js:54: t(/[x\P{OIDS}]/u,
"\u1885\u1886\u2118\u212e\u309b\u309cx");
Is this test missing anchors? Otherwise it will match just due to the 'x'.

https://codereview.chromium.org/2808803002/diff/20001/test/mjsunit/harmony/re...
test/mjsunit/harmony/regexp-property-special.js:56:
t(/^\p{Other_ID_Continue}+$/u, "\u00b7\u0387\u1369\u1371\u19da");
We could include 

0x136A, 0x136B, 0x136C, 0x136D, 0x136E, 0x136F, 0x1370

just to be complete.

[Yang, 2017-04-11 05:55:01]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2017-04-11 05:55:01]

The patchset sent to the CQ was uploaded after l-g-t-m from jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2808803002/#ps60001
(title: "address comments")

[commit-bot: I haz the power, 2017-04-11 05:55:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 07:10:33]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491890101150390,
"parent_rev": "925212a1cfe04eee42a84339e224b66943323805", "commit_rev":
"26e5d0129ca501e4dbadaa098e65222687ce4ab0"}

[commit-bot: I haz the power, 2017-04-11 07:10:39]

Description was changed from

==========
[regexp] implement \p{Other_ID_Start} and \p{Other_ID_Continue}.

Other_ID_Start and Other_ID_Continue are not supported by ICU, so for
now we implement these manually as special binary property classes.

R=jgruber@chromium.org
BUG=v8:4743
==========

to

==========
[regexp] implement \p{Other_ID_Start} and \p{Other_ID_Continue}.

Other_ID_Start and Other_ID_Continue are not supported by ICU, so for
now we implement these manually as special binary property classes.

R=jgruber@chromium.org
BUG=v8:4743

Review-Url: https://codereview.chromium.org/2808803002
Cr-Commit-Position: refs/heads/master@{#44549}
Committed:
https://chromium.googlesource.com/v8/v8/+/26e5d0129ca501e4dbadaa098e65222687c...
==========

[commit-bot: I haz the power, 2017-04-11 07:10:40]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/26e5d0129ca501e4dbadaa098e65222687c...

[Yang, 2017-04-11 09:00:37]

https://codereview.chromium.org/2808803002/diff/20001/test/mjsunit/harmony/re...
File test/mjsunit/harmony/regexp-property-special.js (right):

https://codereview.chromium.org/2808803002/diff/20001/test/mjsunit/harmony/re...
test/mjsunit/harmony/regexp-property-special.js:54: t(/[x\P{OIDS}]/u,
"\u1885\u1886\u2118\u212e\u309b\u309cx");
On 2017/04/10 13:46:50, jgruber wrote:
> Is this test missing anchors? Otherwise it will match just due to the 'x'.

Good catch. Fixed.

https://codereview.chromium.org/2808803002/diff/20001/test/mjsunit/harmony/re...
test/mjsunit/harmony/regexp-property-special.js:56:
t(/^\p{Other_ID_Continue}+$/u, "\u00b7\u0387\u1369\u1371\u19da");
On 2017/04/10 13:46:50, jgruber wrote:
> We could include 
> 
> 0x136A, 0x136B, 0x136C, 0x136D, 0x136E, 0x136F, 0x1370
> 
> just to be complete.

Done.