Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1847)

Unified Diff: chrome/android/java/res/layout/new_tab_page_snippets_card.xml

Issue 2808773002: Fixed ellipsize of publisher instead of timespan string. (Closed)
Patch Set: Refactor variable name. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/new_tab_page_snippets_card.xml
diff --git a/chrome/android/java/res/layout/new_tab_page_snippets_card.xml b/chrome/android/java/res/layout/new_tab_page_snippets_card.xml
index c556447dab9cab1e0784b8274b586d4eb5ea32bd..abf15b44c7e90e34855333fde57e4b0a3884e770 100644
--- a/chrome/android/java/res/layout/new_tab_page_snippets_card.xml
+++ b/chrome/android/java/res/layout/new_tab_page_snippets_card.xml
@@ -69,6 +69,18 @@
android:textColor="@color/snippets_publisher_name_color"
android:textDirection="locale" />
+ <!-- We need to have the publisher and the time span in separete TextViews to be able to
dgn 2017/04/10 21:42:00 s/separete/separate
Galia 2017/04/11 15:54:32 I'll remove that comment and explain all of this i
+ ellipsize the publisher instead of the time span.-->
dgn 2017/04/10 21:42:00 nit: + 4 spaces to align second line of comment wi
Bernhard Bauer 2017/04/10 23:03:03 Also, add a space before the end of the comment.
Galia 2017/04/11 15:54:31 Done.
+ <TextView
+ android:id="@+id/article_time"
dgn 2017/04/10 21:42:00 nit: I think something like article_age is more re
Galia 2017/04/11 15:54:31 Done.
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:drawablePadding="8dp"
dgn 2017/04/10 21:42:00 do you need the drawable padding here? when is it
Galia 2017/04/11 15:54:32 Removed. Thanks.
+ android:maxLines="1"
+ android:textSize="12sp"
+ android:textColor="@color/snippets_publisher_name_color"
+ android:textDirection="locale"/>
+
<!-- We can't add this ImageView as a CompoundDrawable to the TextView because we want to
have different paddings between the favicon (which is a compound drawable on the TextView)
and the offline icon. -->

Powered by Google App Engine
This is Rietveld 408576698