Fixed ellipsize of publisher instead of timespan string.

chrome/android/java/res/layout/new_tab_page_snippets_card.xml

 <?xml version="1.0" encoding="utf-8"?>
 <!-- Copyright 2015 The Chromium Authors. All rights reserved.
      Use of this source code is governed by a BSD-style license that can be
      found in the LICENSE file. -->
 
 <RelativeLayout
     xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:chrome="http://schemas.android.com/apk/res-auto"
     xmlns:tools="http://schemas.android.com/tools"
     android:id="@+id/snippets_card_view"
@@ skipping 37 matching lines @@
         android:layout_marginTop="@dimen/snippets_publisher_margin_top_with_article_snippet"
         android:layout_alignParentStart="true"
         android:layout_below="@+id/article_snippet"
         android:orientation="horizontal">
 
         <!-- The following attributes:
         - LinearLayout's android:layout_width="wrap_content"
         - TextView's android:layout_width="0dp"
         - TextView's android:layout_weight="1"
         All ensure that when the TextView is long and the ImageView is showing, the TextView starts
         to ellipsize before pushing the ImageView off the screen. See: https://crbug.com/678568 -->

[dgn, 2017/04/10 21:42:00]

nit: update the description. The thing it would be pushing off the screen here
is the suggestion age.

[Galia, 2017/04/11 15:54:32]

Done.

         <TextView
             android:id="@+id/article_publisher"
             android:layout_width="0dp"
             android:layout_weight="1"
             android:layout_height="wrap_content"
             android:drawablePadding="8dp"
             android:paddingStart="4dp"
             android:maxLines="1"
             android:ellipsize="end"
             android:textSize="12sp"
             android:textColor="@color/snippets_publisher_name_color"
             android:textDirection="locale" />
 
+        <!-- We need to have the publisher and the time span in separete TextViews to be able to

[dgn, 2017/04/10 21:42:00]

s/separete/separate

[Galia, 2017/04/11 15:54:32]

I'll remove that comment and explain all of this in the one above the two
TextViews.

+        ellipsize the publisher instead of the time span.-->

[dgn, 2017/04/10 21:42:00]

nit: + 4 spaces to align second line of comment with first letter of the actual
comment above. For comment style, the comment below is wrong, the comment in the
copyright notice is right.

[Bernhard Bauer, 2017/04/10 23:03:03]

Also, add a space before the end of the comment.

[Galia, 2017/04/11 15:54:31]

Done.

+        <TextView
+            android:id="@+id/article_time"

[dgn, 2017/04/10 21:42:00]

nit: I think something like article_age is more representative of the value of
this field. If you update it, also update the variables in the view holder.

[Galia, 2017/04/11 15:54:31]

Done.

+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:drawablePadding="8dp"

[dgn, 2017/04/10 21:42:00]

do you need the drawable padding here? when is it used?

[Galia, 2017/04/11 15:54:32]

Removed. Thanks.

+            android:maxLines="1"
+            android:textSize="12sp"
+            android:textColor="@color/snippets_publisher_name_color"
+            android:textDirection="locale"/>
+
         <!-- We can't add this ImageView as a CompoundDrawable to the TextView because we want to
         have different paddings between the favicon (which is a compound drawable on the TextView)
         and the offline icon. -->
         <org.chromium.chrome.browser.widget.TintedImageView
             android:id="@+id/offline_icon"
             android:layout_width="@dimen/snippets_offline_icon_size"
             android:layout_height="@dimen/snippets_offline_icon_size"
             android:layout_marginStart="6dp"
             android:alpha="0.54"
             android:src="@drawable/offline_pin_round"
             android:contentDescription="@string/accessibility_ntp_offline_badge"
             android:visibility="gone"
             chrome:tint="#000" />
 
     </LinearLayout>
 
     <org.chromium.chrome.browser.widget.TintedImageView
         android:id="@+id/article_thumbnail"
         android:layout_width="@dimen/snippets_thumbnail_size"
         android:layout_height="@dimen/snippets_thumbnail_size"
         android:layout_alignParentTop="true"
         android:layout_alignParentEnd="true"
         android:layout_marginStart="@dimen/snippets_thumbnail_margin"
         android:scaleType="centerCrop"
         android:contentDescription="@null"
         android:src="@null" />
 </RelativeLayout>