Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2808763012:
Fix uninitialized variable in VideoRendererImplTest (Closed)
|
Created:
3 years, 8 months ago by servolk Modified:
3 years, 8 months ago Reviewers:
DaleCurtis CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix uninitialized variable in VideoRendererImplTest
The |expect_init_success_| variable is typically initialized in
InitializeRenderer, but the DestroyWhileInitializing test case invokes
CallInitialize directly, which will invoke CreateVideoDecodersForTest
before the InitializeRenderer runs, so we need to ensure
expect_init_success_ is always initialized.
BUG=711318
Review-Url: https://codereview.chromium.org/2808763012
Cr-Commit-Position: refs/heads/master@{#464495}
Committed: https://chromium.googlesource.com/chromium/src/+/786d0251c33344501eed4dc016e84416bad11fe1
Patch Set 1 #Patch Set 2 : Reenable the DestroyWhileInitializing test #Patch Set 3 : fix conflict #Messages
Total messages: 22 (17 generated)
The CQ bit was checked by servolk@chromium.org to run a CQ dry run
Description was changed from ========== Fix uninitialized variable in VideoRendererImplTest The |expect_init_success_| variable is typically initialized in InitializeRenderer, but the DestroyWhileInitializing test case invokes CallInitialize directly, which will invoke CreateVideoDecodersForTest before the InitializeRenderer runs, so we need to ensure expect_init_success_ is always initialized. BUG=711318 ========== to ========== Fix uninitialized variable in VideoRendererImplTest The |expect_init_success_| variable is typically initialized in InitializeRenderer, but the DestroyWhileInitializing test case invokes CallInitialize directly, which will invoke CreateVideoDecodersForTest before the InitializeRenderer runs, so we need to ensure expect_init_success_ is always initialized. BUG=711318 ==========
servolk@chromium.org changed reviewers: + dalecurtis@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by servolk@chromium.org
The CQ bit was checked by servolk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by servolk@chromium.org
The CQ bit was checked by servolk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by servolk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by servolk@chromium.org
The CQ bit was checked by servolk@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dalecurtis@chromium.org Link to the patchset: https://codereview.chromium.org/2808763012/#ps40001 (title: "fix conflict")
The CQ bit was checked by servolk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492109176053520,
"parent_rev": "d512803299c01324b92ffd8c962da97e3bc8ccff", "commit_rev":
"786d0251c33344501eed4dc016e84416bad11fe1"}
Message was sent while issue was closed.
Description was changed from ========== Fix uninitialized variable in VideoRendererImplTest The |expect_init_success_| variable is typically initialized in InitializeRenderer, but the DestroyWhileInitializing test case invokes CallInitialize directly, which will invoke CreateVideoDecodersForTest before the InitializeRenderer runs, so we need to ensure expect_init_success_ is always initialized. BUG=711318 ========== to ========== Fix uninitialized variable in VideoRendererImplTest The |expect_init_success_| variable is typically initialized in InitializeRenderer, but the DestroyWhileInitializing test case invokes CallInitialize directly, which will invoke CreateVideoDecodersForTest before the InitializeRenderer runs, so we need to ensure expect_init_success_ is always initialized. BUG=711318 Review-Url: https://codereview.chromium.org/2808763012 Cr-Commit-Position: refs/heads/master@{#464495} Committed: https://chromium.googlesource.com/chromium/src/+/786d0251c33344501eed4dc016e8... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/786d0251c33344501eed4dc016e8... |
