Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2808763010: Revert of Fix flaky NPE in oobe.js. (Closed)

Created:
3 years, 8 months ago by kinaba
Modified:
3 years, 8 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of Fix flaky NPE in oobe.js. (patchset #1 id:1 of https://codereview.chromium.org/2803043002/ ) Reason for revert: Breaking existing tests. (crbug.com/710975) Original issue's description: > Fix flaky NPE in oobe.js. > > Under some racy condition, telemetry accesses the DOM object before ready. > This CL observes a new variable which is set to true when DOM is ready. > > BUG=chromium:709041 > TEST=Ran try. Ran on ChromeOS device with corresponding CL. > > Review-Url: https://codereview.chromium.org/2803043002 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/9a55abab029cb9ae94f5160ded11b09a4638a955 TBR=achuith@chromium.org,hidehiko@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:709041 Review-Url: https://codereview.chromium.org/2808763010 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/f49ec2dcbd4701deac2247e4aa59e9cbf281b4dc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M telemetry/telemetry/internal/backends/chrome/oobe.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
kinaba
Created Revert of Fix flaky NPE in oobe.js.
3 years, 8 months ago (2017-04-13 08:38:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808763010/1
3 years, 8 months ago (2017-04-13 08:38:38 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-13 08:38:39 UTC) #5
kinaba
3 years, 8 months ago (2017-04-13 08:38:43 UTC) #7
kinaba
self-lgtm to kick CQ
3 years, 8 months ago (2017-04-13 08:46:49 UTC) #8
kinaba
On 2017/04/13 08:46:49, kinaba wrote: > self-lgtm to kick CQ hm, maybe it's not working ...
3 years, 8 months ago (2017-04-13 08:48:52 UTC) #9
Shuhei Takahashi
trying lgtm
3 years, 8 months ago (2017-04-13 08:52:29 UTC) #10
hidehiko
lgtm.
3 years, 8 months ago (2017-04-13 12:54:28 UTC) #11
achuithb
lgtm
3 years, 8 months ago (2017-04-13 18:23:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808763010/1
3 years, 8 months ago (2017-04-13 18:23:55 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 18:48:02 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698