Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2808743005: [wasm] Compile closer to how customers will. (Closed)

Created:
3 years, 8 months ago by Mircea Trofin
Modified:
3 years, 8 months ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[wasm] Compile closer to how customers will. Ensure we don't regress from https://codereview.chromium.org/2812543002/ Although the fix is on the v8 side, the issue requires Blink-specifics. Regression testing on V8's side, in this case, would be a bit artificial. BUG=chromium:709684 Review-Url: https://codereview.chromium.org/2808743005 Cr-Commit-Position: refs/heads/master@{#463606} Committed: https://chromium.googlesource.com/chromium/src/+/a9ec6cb4b268d78bd6efc1327758e40067e4a304

Patch Set 1 #

Patch Set 2 : [wasm] Compile closer to how customers will. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/fast/wasm/wasm-limits-test.html View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/wasm/wasm-limits-tests.js View 1 chunk +23 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/wasm/resources/load_wasm.js View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Mircea Trofin
3 years, 8 months ago (2017-04-11 04:46:20 UTC) #5
jochen (gone - plz use gerrit)
lgtm
3 years, 8 months ago (2017-04-11 07:40:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808743005/20001
3 years, 8 months ago (2017-04-11 12:49:23 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 12:54:05 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a9ec6cb4b268d78bd6efc1327758...

Powered by Google App Engine
This is Rietveld 408576698