Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2808743004: Include builtin_audio_encoder_factory.h in peer_connection_dependency_factory.cc (Closed)

Created:
3 years, 8 months ago by ossu-chromium
Modified:
3 years, 7 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, kwiberg-chromium
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Include builtin_audio_encoder_factory.h in peer_connection_dependency_factory.cc Also add builtin_audio_encoder_factory to deps. Also move the builtin_audio_decoder_factory into the deps that's added only if building with webrtc. BUG=webrtc:5806 Review-Url: https://codereview.chromium.org/2808743004 Cr-Commit-Position: refs/heads/master@{#471747} Committed: https://chromium.googlesource.com/chromium/src/+/578c5aa7e965ad70d31a0372fb7532b030781d05

Patch Set 1 #

Patch Set 2 : Added builtin_audio_encoder_factory to deps and moved builtin_audio_decoder_factory. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/renderer/BUILD.gn View 1 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/media/webrtc/peer_connection_dependency_factory.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
ossu-chromium
This CL adds a direct dependency and include of webrtc::BuiltinAudioEncoderFactory to PeerConnectionDependencyFactory. It was previously ...
3 years, 7 months ago (2017-05-09 16:01:42 UTC) #11
ossu-chromium
Ping! This should be a real quick change to validate and will let me finish ...
3 years, 7 months ago (2017-05-11 08:53:45 UTC) #12
ncarter (slow)
lgtm
3 years, 7 months ago (2017-05-11 17:11:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808743004/20001
3 years, 7 months ago (2017-05-15 08:58:34 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/444288)
3 years, 7 months ago (2017-05-15 10:48:35 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808743004/20001
3 years, 7 months ago (2017-05-15 11:08:16 UTC) #19
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 13:45:07 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/578c5aa7e965ad70d31a0372fb75...

Powered by Google App Engine
This is Rietveld 408576698