Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2808703002: Make NinePieceImageData use RefCountedCopyable. (Closed)

Created:
3 years, 8 months ago by shend
Modified:
3 years, 8 months ago
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make NinePieceImageData use RefCountedCopyable. NinePieceImageData is RefCounted and copyable. This patch makes it inherit from RefCountedCopyable so that it can use the compiler generated copy constructor. BUG=628043 Review-Url: https://codereview.chromium.org/2808703002 Cr-Commit-Position: refs/heads/master@{#465133} Committed: https://chromium.googlesource.com/chromium/src/+/20e570ab5950d95673078e4edd1653faf97812b0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -12 lines) Patch
M third_party/WebKit/Source/core/style/NinePieceImage.h View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/NinePieceImage.cpp View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
shend
Hi Naina, PTAL
3 years, 8 months ago (2017-04-10 05:17:30 UTC) #2
nainar
lgtm
3 years, 8 months ago (2017-04-10 17:19:03 UTC) #3
shend
Hi Eddy, PTAL
3 years, 8 months ago (2017-04-12 04:10:40 UTC) #5
shend
Redirecting to Suzy, PTAL
3 years, 8 months ago (2017-04-18 00:01:05 UTC) #7
suzyh_UTC10 (ex-contributor)
On 2017/04/18 at 00:01:05, shend wrote: > Redirecting to Suzy, PTAL lgtm I'd recommend adding ...
3 years, 8 months ago (2017-04-18 00:38:01 UTC) #8
shend
On 2017/04/18 at 00:38:01, suzyh wrote: > On 2017/04/18 at 00:01:05, shend wrote: > > ...
3 years, 8 months ago (2017-04-18 01:14:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808703002/1
3 years, 8 months ago (2017-04-18 03:55:21 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 03:59:32 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/20e570ab5950d95673078e4edd16...

Powered by Google App Engine
This is Rietveld 408576698