Issue 2808663005: Add sanitizer deps to transport security state generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2808663005: Add sanitizer deps to transport security state generator. (Closed)

Created:
3 years, 8 months ago by martijnc

Modified:
3 years, 8 months ago

Reviewers:
brettw, Ryan Sleevi

CC:
cbentzel+watch_chromium.org, chromium-reviews, net-reviews_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

Add sanitizer deps to transport security state generator. BUG=710012

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	net/tools/transport_security_state_generator/BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

martijnc

This dependency seems required to get everything to link on the Debug ASAN bots. I've ...

3 years, 8 months ago (2017-04-10 17:11:01 UTC) #2

martijnc

There is another CL (https://codereview.chromium.org/2808863003) that adds the dependency for the generator and a couple ...

3 years, 8 months ago (2017-04-12 16:07:26 UTC) #4

brettw

3 years, 8 months ago (2017-04-12 20:44:24 UTC) #5

Message was sent while issue was closed.

Yeah, every executable should have these for it to compile in sanitizer mode.
LGTM