Explicitly tell the preload request where to take the referrer from

Explicitly tell the preload request where to take the referrer from

BUG=709625
R=estark@chromium.org,yoav@yoav.ws

Review-Url: https://codereview.chromium.org/2808663003
Cr-Commit-Position: refs/heads/master@{#463264}
Committed: https://chromium.googlesource.com/chromium/src/+/b4c4f2c525c4bc3e1494291cb8b83ebbb298c050

[jochen (gone - plz use gerrit), 2017-04-10 12:28:22]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 12:28:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yoav Weiss, 2017-04-10 12:38:44]

LGTM

https://codereview.chromium.org/2808663003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp
(right):

https://codereview.chromium.org/2808663003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp:51:
expected_referrer;  // Or nullptr if the header shouldn't be checked.
Nit: I'm still getting used to chromium style, so feel free to ignore, but I
think having a single line comment above the definition (and having the entire
definition in a single line) would be clearer.

[jochen (gone - plz use gerrit), 2017-04-10 12:47:14]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 12:47:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 12:52:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 12:52:28]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[jochen (gone - plz use gerrit), 2017-04-10 13:06:24]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2017-04-10 13:06:24]

The patchset sent to the CQ was uploaded after l-g-t-m from yoav@yoav.ws
Link to the patchset: https://codereview.chromium.org/2808663003/#ps20001
(title: "comment")

[jochen (gone - plz use gerrit), 2017-04-10 13:06:31]

https://codereview.chromium.org/2808663003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp
(right):

https://codereview.chromium.org/2808663003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp:51:
expected_referrer;  // Or nullptr if the header shouldn't be checked.
On 2017/04/10 at 12:38:44, Yoav Weiss wrote:
> Nit: I'm still getting used to chromium style, so feel free to ignore, but I
think having a single line comment above the definition (and having the entire
definition in a single line) would be clearer.

both are fine. I made the comment a bit longer and moved it before the field

[commit-bot: I haz the power, 2017-04-10 13:06:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 13:12:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 13:12:09]

Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[jochen (gone - plz use gerrit), 2017-04-10 13:21:56]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2017-04-10 13:22:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 14:48:45]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491830516363280,
"parent_rev": "06c594634073ae8cc37099fadd15cd02ae035398", "commit_rev":
"b4c4f2c525c4bc3e1494291cb8b83ebbb298c050"}

[commit-bot: I haz the power, 2017-04-10 14:49:39]

Description was changed from

==========
Explicitly tell the preload request where to take the referrer from

BUG=709625
R=estark@chromium.org,yoav@yoav.ws
==========

to

==========
Explicitly tell the preload request where to take the referrer from

BUG=709625
R=estark@chromium.org,yoav@yoav.ws

Review-Url: https://codereview.chromium.org/2808663003
Cr-Commit-Position: refs/heads/master@{#463264}
Committed:
https://chromium.googlesource.com/chromium/src/+/b4c4f2c525c4bc3e1494291cb8b8...
==========

[commit-bot: I haz the power, 2017-04-10 14:49:40]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b4c4f2c525c4bc3e1494291cb8b8...