Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: chrome/browser/resources/engagement/site_engagement.html

Issue 2808663002: Add base and bonus scores to site-engagement WebUI. (Closed)
Patch Set: Address review comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/engagement/site_engagement.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/engagement/site_engagement.html
diff --git a/chrome/browser/resources/engagement/site_engagement.html b/chrome/browser/resources/engagement/site_engagement.html
index 9a7f960ddde6da6a86735a582f428cd2f4f9b4b0..a613730dac05a9cf8b37793aec32f8261a12f4ce 100644
--- a/chrome/browser/resources/engagement/site_engagement.html
+++ b/chrome/browser/resources/engagement/site_engagement.html
@@ -26,6 +26,7 @@
background: rgb(224, 236, 255);
cursor: pointer;
padding-bottom: 4px;
+ padding-right: 16px;
padding-top: 4px;
calamity 2017/04/19 02:46:37 nit: Actually, can you remove all the paddings her
Wez 2017/04/21 00:41:42 Done.
white-space: nowrap;
}
@@ -44,19 +45,21 @@
min-width: 500px;
}
- .score-cell {
+ .base-score-cell,
+ .bonus-score-cell,
+ .total-score-cell {
background-color: rgba(230, 230, 230, 0.5);
text-align: right;
}
- .score-input {
+ .base-score-input {
border: 1px solid #ccc;
border-radius: 2px;
text-align: right;
width: 70px;
}
- .score-input:focus {
+ .base-score-input:focus {
border: 1px solid rgb(143, 185, 252);
box-shadow: 0 0 2px rgb(113, 158, 206);
outline: none;
@@ -68,10 +71,12 @@
th.sort-column::after {
content: '▲';
+ position: absolute;
}
th[sort-reverse].sort-column::after {
content: '▼';
+ position: absolute;
}
</style>
</head>
@@ -83,8 +88,14 @@
<th sort-key="origin">
Origin
</th>
+ <th sort-key="base_score" sort-reverse>
+ Base
+ </th>
+ <th sort-key="bonus_score" sort-reverse>
+ Bonus
+ </th>
<th sort-key="total_score" class="sort-column" sort-reverse>
- Points
+ Total
</th>
</tr>
</thead>
« no previous file with comments | « no previous file | chrome/browser/resources/engagement/site_engagement.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698