Chromium Code Reviews Chromium Code Reviews
Issue 2808663002:
Add base and bonus scores to site-engagement WebUI. (Closed)
| OLD | NEW |
|---|---|
| 1 <!doctype html> | 1 <!doctype html> |
| 2 <head> | 2 <head> |
| 3 <title>Site Engagement</title> | 3 <title>Site Engagement</title> |
| 4 <meta charset="utf-8"> | 4 <meta charset="utf-8"> |
| 5 <link rel="stylesheet" href="chrome://resources/css/text_defaults.css"> | 5 <link rel="stylesheet" href="chrome://resources/css/text_defaults.css"> |
| 6 <script src="chrome://resources/js/util.js"></script> | 6 <script src="chrome://resources/js/util.js"></script> |
| 7 <script src="chrome://site-engagement/site_engagement.js"></script> | 7 <script src="chrome://site-engagement/site_engagement.js"></script> |
| 8 <style> | 8 <style> |
| 9 body { | 9 body { |
| 10 font-family: 'Roboto', 'Noto', sans-serif; | 10 font-family: 'Roboto', 'Noto', sans-serif; |
| 11 font-size: 14px; | 11 font-size: 14px; |
| 12 } | 12 } |
| 13 | 13 |
| 14 table { | 14 table { |
| 15 border-collapse: collapse; | 15 border-collapse: collapse; |
| 16 } | 16 } |
| 17 | 17 |
| 18 table td, | 18 table td, |
| 19 table th { | 19 table th { |
| 20 border: 1px solid #777; | 20 border: 1px solid #777; |
| 21 padding-left: 4px; | 21 padding-left: 4px; |
| 22 padding-right: 4px; | 22 padding-right: 4px; |
| 23 } | 23 } |
| 24 | 24 |
| 25 table th { | 25 table th { |
| 26 background: rgb(224, 236, 255); | 26 background: rgb(224, 236, 255); |
| 27 cursor: pointer; | 27 cursor: pointer; |
| 28 padding-bottom: 4px; | 28 padding-bottom: 4px; |
| 29 padding-right: 16px; | |
| 29 padding-top: 4px; | 30 padding-top: 4px; |
|
calamity
2017/04/19 02:46:37
nit: Actually, can you remove all the paddings her
Wez
2017/04/21 00:41:42
Done.
| |
| 30 white-space: nowrap; | 31 white-space: nowrap; |
| 31 } | 32 } |
| 32 | 33 |
| 33 .engagement-bar { | 34 .engagement-bar { |
| 34 background-color: black; | 35 background-color: black; |
| 35 height: 2px; | 36 height: 2px; |
| 36 } | 37 } |
| 37 | 38 |
| 38 .engagement-bar-cell { | 39 .engagement-bar-cell { |
| 39 border: none; | 40 border: none; |
| 40 } | 41 } |
| 41 | 42 |
| 42 .origin-cell { | 43 .origin-cell { |
| 43 background-color: rgba(230, 230, 230, 0.5); | 44 background-color: rgba(230, 230, 230, 0.5); |
| 44 min-width: 500px; | 45 min-width: 500px; |
| 45 } | 46 } |
| 46 | 47 |
| 47 .score-cell { | 48 .base-score-cell, |
| 49 .bonus-score-cell, | |
| 50 .total-score-cell { | |
| 48 background-color: rgba(230, 230, 230, 0.5); | 51 background-color: rgba(230, 230, 230, 0.5); |
| 49 text-align: right; | 52 text-align: right; |
| 50 } | 53 } |
| 51 | 54 |
| 52 .score-input { | 55 .base-score-input { |
| 53 border: 1px solid #ccc; | 56 border: 1px solid #ccc; |
| 54 border-radius: 2px; | 57 border-radius: 2px; |
| 55 text-align: right; | 58 text-align: right; |
| 56 width: 70px; | 59 width: 70px; |
| 57 } | 60 } |
| 58 | 61 |
| 59 .score-input:focus { | 62 .base-score-input:focus { |
| 60 border: 1px solid rgb(143, 185, 252); | 63 border: 1px solid rgb(143, 185, 252); |
| 61 box-shadow: 0 0 2px rgb(113, 158, 206); | 64 box-shadow: 0 0 2px rgb(113, 158, 206); |
| 62 outline: none; | 65 outline: none; |
| 63 } | 66 } |
| 64 | 67 |
| 65 table tr:hover { | 68 table tr:hover { |
| 66 background: rgb(255, 255, 187); | 69 background: rgb(255, 255, 187); |
| 67 } | 70 } |
| 68 | 71 |
| 69 th.sort-column::after { | 72 th.sort-column::after { |
| 70 content: '▲'; | 73 content: '▲'; |
| 74 position: absolute; | |
| 71 } | 75 } |
| 72 | 76 |
| 73 th[sort-reverse].sort-column::after { | 77 th[sort-reverse].sort-column::after { |
| 74 content: '▼'; | 78 content: '▼'; |
| 79 position: absolute; | |
| 75 } | 80 } |
| 76 </style> | 81 </style> |
| 77 </head> | 82 </head> |
| 78 <body> | 83 <body> |
| 79 <h1>Site Engagement</h1> | 84 <h1>Site Engagement</h1> |
| 80 <table> | 85 <table> |
| 81 <thead> | 86 <thead> |
| 82 <tr id="engagement-table-header"> | 87 <tr id="engagement-table-header"> |
| 83 <th sort-key="origin"> | 88 <th sort-key="origin"> |
| 84 Origin | 89 Origin |
| 85 </th> | 90 </th> |
| 91 <th sort-key="base_score" sort-reverse> | |
| 92 Base | |
| 93 </th> | |
| 94 <th sort-key="bonus_score" sort-reverse> | |
| 95 Bonus | |
| 96 </th> | |
| 86 <th sort-key="total_score" class="sort-column" sort-reverse> | 97 <th sort-key="total_score" class="sort-column" sort-reverse> |
| 87 Points | 98 Total |
| 88 </th> | 99 </th> |
| 89 </tr> | 100 </tr> |
| 90 </thead> | 101 </thead> |
| 91 <tbody id="engagement-table-body"> | 102 <tbody id="engagement-table-body"> |
| 92 </tbody> | 103 </tbody> |
| 93 </table> | 104 </table> |
| 94 </body> | 105 </body> |
| 95 </html> | 106 </html> |
| OLD | NEW |
