Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2808653004: Use the 30 day history stats for the Data Saver menu item (Closed)

Created:
3 years, 8 months ago by megjablon
Modified:
3 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, agrieve+watch_chromium.org, tbansal+watch-data-reduction-proxy_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the 30 day history stats for the Data Saver menu item The Data Saver menu item should display the savings for the last 30 days rather than lifetime savings. BUG=702799 Review-Url: https://codereview.chromium.org/2808653004 Cr-Commit-Position: refs/heads/master@{#463699} Committed: https://chromium.googlesource.com/chromium/src/+/dc6f2e8e9f1c909c48d403c8e5a183a8769f2c03

Patch Set 1 #

Total comments: 2

Patch Set 2 : dtrainor comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java View 1 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionMainMenuFooter.java View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (13 generated)
megjablon
PTAL, thanks!
3 years, 8 months ago (2017-04-11 01:56:41 UTC) #4
David Trainor- moved to gerrit
lgtm % nit https://codereview.chromium.org/2808653004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java File chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java (right): https://codereview.chromium.org/2808653004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java#newcode215 chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java:215: savings = length.getOriginal() - length.getReceived(); long ...
3 years, 8 months ago (2017-04-11 05:04:03 UTC) #7
megjablon
https://codereview.chromium.org/2808653004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java File chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java (right): https://codereview.chromium.org/2808653004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java#newcode215 chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java:215: savings = length.getOriginal() - length.getReceived(); On 2017/04/11 05:04:03, David ...
3 years, 8 months ago (2017-04-11 17:30:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808653004/20001
3 years, 8 months ago (2017-04-11 18:31:41 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 18:42:21 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dc6f2e8e9f1c909c48d403c8e5a1...

Powered by Google App Engine
This is Rietveld 408576698