make headless lib complie when enable_basic_printing is set to false

make headless lib complie when enable_basic_printing is set to false

There is a bug that headless lib doesn't complie when users set 
enable_basic_printing to false in their args.gn file.

The patch ensure that the printing support is only avaliable when 
enable_basic_printing is true.
When it is false, the PrintToPDF devtools command would return an error instead.

BUG=603559
Review-Url: https://codereview.chromium.org/2808653002
Cr-Commit-Position: refs/heads/master@{#463381}
Committed: https://chromium.googlesource.com/chromium/src/+/143099e30f56d3d41c6e1fb49230586472751aac

[jzfeng, 2017-04-10 01:46:08]

Description was changed from

==========
make headless lib complie when enable_basic_printing is set to false

There is a bug that headless lib doesn't complie when users set
enable_basic_printing to false in their args.gn file.

The patch ensure that the printing support is only avaliable when
enable_basic_printing is true.
When it is false, the PrintToPDF devtools command would return an error instead.

BUG=603559
==========

to

==========
make headless lib complie when enable_basic_printing is set to false

There is a bug that headless lib doesn't complie when users set 
enable_basic_printing to false in their args.gn file.

The patch ensure that the printing support is only avaliable when 
enable_basic_printing is true.
When it is false, the PrintToPDF devtools command would return an error instead.

BUG=603559
==========

[jzfeng, 2017-04-10 01:50:39]

The CQ bit was checked by jzfeng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 01:50:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jzfeng, 2017-04-10 02:28:49]

jzfeng@chromium.org changed reviewers:
+ eseckler@chromium.org, thestig@chromium.org

[jzfeng, 2017-04-10 02:28:49]

This is a patch to fix the bug reported in
https://bugs.chromium.org/p/chromium/issues/detail?id=603559#c17.

PTAL.

Thanks!

[commit-bot: I haz the power, 2017-04-10 03:49:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 03:49:53]

Dry run: This issue passed the CQ dry run.

[Eric Seckler, 2017-04-10 06:48:02]

lgtm

[Lei Zhang, 2017-04-10 17:38:41]

lgtm

https://codereview.chromium.org/2808653002/diff/20001/headless/lib/browser/he...
File headless/lib/browser/headless_devtools_manager_delegate.cc (right):

https://codereview.chromium.org/2808653002/diff/20001/headless/lib/browser/he...
headless/lib/browser/headless_devtools_manager_delegate.cc:192: #if
!BUILDFLAG(ENABLE_BASIC_PRINTING)
Maybe remove the '!' and swap the two bodies of code?

https://codereview.chromium.org/2808653002/diff/20001/headless/lib/browser/he...
headless/lib/browser/headless_devtools_manager_delegate.cc:197: "args.gn"));
Just say something like "printing is not enabled" - end users do not know
anything about Chromium build settings.

[jzfeng, 2017-04-10 18:32:26]

The CQ bit was checked by jzfeng@chromium.org

[jzfeng, 2017-04-10 18:32:27]

Thanks for the review!

https://codereview.chromium.org/2808653002/diff/20001/headless/lib/browser/he...
File headless/lib/browser/headless_devtools_manager_delegate.cc (right):

https://codereview.chromium.org/2808653002/diff/20001/headless/lib/browser/he...
headless/lib/browser/headless_devtools_manager_delegate.cc:192: #if
!BUILDFLAG(ENABLE_BASIC_PRINTING)
On 2017/04/10 at 17:38:41, Lei Zhang wrote:
> Maybe remove the '!' and swap the two bodies of code?

Done.

https://codereview.chromium.org/2808653002/diff/20001/headless/lib/browser/he...
headless/lib/browser/headless_devtools_manager_delegate.cc:197: "args.gn"));
On 2017/04/10 at 17:38:41, Lei Zhang wrote:
> Just say something like "printing is not enabled" - end users do not know
anything about Chromium build settings.

Done.

[jzfeng, 2017-04-10 18:32:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, eseckler@chromium.org
Link to the patchset: https://codereview.chromium.org/2808653002/#ps40001
(title: "minor fix")

[commit-bot: I haz the power, 2017-04-10 18:33:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 20:18:13]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491849146667690,
"parent_rev": "244727d064719e08f022323fecba95ccac5e69c6", "commit_rev":
"143099e30f56d3d41c6e1fb49230586472751aac"}

[commit-bot: I haz the power, 2017-04-10 20:19:02]

Description was changed from

==========
make headless lib complie when enable_basic_printing is set to false

There is a bug that headless lib doesn't complie when users set 
enable_basic_printing to false in their args.gn file.

The patch ensure that the printing support is only avaliable when 
enable_basic_printing is true.
When it is false, the PrintToPDF devtools command would return an error instead.

BUG=603559
==========

to

==========
make headless lib complie when enable_basic_printing is set to false

There is a bug that headless lib doesn't complie when users set 
enable_basic_printing to false in their args.gn file.

The patch ensure that the printing support is only avaliable when 
enable_basic_printing is true.
When it is false, the PrintToPDF devtools command would return an error instead.

BUG=603559

Review-Url: https://codereview.chromium.org/2808653002
Cr-Commit-Position: refs/heads/master@{#463381}
Committed:
https://chromium.googlesource.com/chromium/src/+/143099e30f56d3d41c6e1fb49230...
==========

[commit-bot: I haz the power, 2017-04-10 20:19:03]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/143099e30f56d3d41c6e1fb49230...

[jzfeng, 2017-04-24 22:50:09]

Patchset #4 (id:60001) has been deleted