chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc - Issue 280863002: Reduce creation of ViewsDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc

Issue 280863002: Reduce creation of ViewsDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add widget includes for undef CreateWindow Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/sync_error_notifier_ash_unittest.cc ('k') | chrome/browser/ui/ash/test_views_delegate_with_parent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc

diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc

index 887cf81c04a1ad959715a14afa0811ce807adf63..5ce00fcdb13cd437ace5d621da33eb92b02f4d41 100644

--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc

+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc

@@ -27,7 +27,6 @@

#include "chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.h"

#include "chrome/browser/ui/ash/launcher/launcher_application_menu_item_model.h"

#include "chrome/browser/ui/ash/launcher/launcher_item_controller.h"

-#include "chrome/browser/ui/ash/test_views_delegate_with_parent.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_commands.h"

#include "chrome/browser/ui/browser_finder.h"

@@ -922,10 +921,6 @@ class MultiProfileMultiBrowserShelfLayoutChromeLauncherControllerTest

created_profiles_.erase(it);

}

- virtual views::ViewsDelegate* CreateViewsDelegate() OVERRIDE {

- return new TestViewsDelegateWithParent;

- }

private:

typedef std::map<Profile*, std::string> ProfileToNameMap;

TestingProfileManager* profile_manager() { return profile_manager_.get(); }

« no previous file with comments | « chrome/browser/sync/sync_error_notifier_ash_unittest.cc ('k') | chrome/browser/ui/ash/test_views_delegate_with_parent.h » ('j') | no next file with comments »