PaymentRequest: Change the timer task type.

third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

Index: third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp b/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
index 63e221476b9c5d4619f63e40ddda08f1023310d6..a45ff6c4ecc546388cafce87ec6441a19e43a891 100644
--- a/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
+++ b/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
@@ -854,7 +854,7 @@ PaymentRequest::PaymentRequest(ExecutionContext* executionContext,
     : ContextLifecycleObserver(executionContext),
       m_options(options),
       m_clientBinding(this),
-      m_completeTimer(TaskRunnerHelper::get(TaskType::MiscPlatformAPI, frame()),
+      m_completeTimer(TaskRunnerHelper::get(TaskType::UserInteraction, frame()),

[please use gerrit instead, 2017/04/10 15:35:06]

Please don't change this line.

According to the spec, user interaction timers should be used only for
'shippingaddresschange' and 'shippingoptionchange' methods. These two timers are
in PaymentRequestUpdateEvent.abort_timer_. So you're good there.

There's some language about queueing a task in user interaction task source for
.abort() method, but there's no delay specified in there. Because Chromium's
implementation of .abort() is asynchronous, we don't need a timer. 

[zino, 2017/04/10 16:11:12]

I was confused here: User accepts the payment request algorithm
https://w3c.github.io/browser-payment-api/#user-accepts-the-payment-request-a...
https://w3c.github.io/browser-payment-api/#complete-method

But my thought was incorrect according to your explaination.
After show() has been resolved, if we do not call complete(), then user
interface is blocked.
So, it's used for causing timeout if the page never calls complete().

Then, do we have to change it to kTimer vs kUnspecedTimer? WDYT?

[please use gerrit instead, 2017/04/10 16:12:52]

We cannot keep MiscPlatformAPI task type?

                       this,
                       &PaymentRequest::onCompleteTimeout) {
   Vector<payments::mojom::blink::PaymentMethodDataPtr> validatedMethodData;