Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2808563002: Revert of media: Implement MediaDrmStorageImpl with tests (Closed)

Created:
3 years, 8 months ago by Xi Han
Modified:
3 years, 8 months ago
Reviewers:
yucliu1, xhwang, sdefresne
CC:
chromium-reviews, eme-reviews_chromium.org, avayvod+watch_chromium.org, mlamouri+watch-media_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of media: Implement MediaDrmStorageImpl with tests (patchset #4 id:60001 of https://codereview.chromium.org/2791903004/ ) Reason for revert: This CL causes MediaDrmStorageImplTest failing on chromium.linux/Android Tests: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests/builds/40330 BUG=709601 Original issue's description: > media: Implement MediaDrmStorageImpl with tests > > Implement MediaDrmStorageImpl using PrefService. > > TBR=sdefresne@chromium.org > BUG=493521 > TEST=New unit tests added. > > Review-Url: https://codereview.chromium.org/2791903004 > Cr-Commit-Position: refs/heads/master@{#462929} > Committed: https://chromium.googlesource.com/chromium/src/+/d0b7b3b7e9f7d4e4c1f8276c5b416eaa05ac9bb0 TBR=yucliu@chromium.org,sdefresne@chromium.org,xhwang@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=493521 Review-Url: https://codereview.chromium.org/2808563002 Cr-Commit-Position: refs/heads/master@{#462988} Committed: https://chromium.googlesource.com/chromium/src/+/f5fa6d693cae9dfcdb66bdfd70752975c7d9bef4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -380 lines) Patch
M components/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/cdm/browser/BUILD.gn View 1 chunk +0 lines, -14 lines 0 comments Download
M components/cdm/browser/media_drm_storage_impl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M components/cdm/browser/media_drm_storage_impl.cc View 12 chunks +17 lines, -161 lines 0 comments Download
D components/cdm/browser/media_drm_storage_impl_unittest.cc View 1 chunk +0 lines, -196 lines 0 comments Download
M media/base/android/media_drm_storage.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Xi Han
Created Revert of media: Implement MediaDrmStorageImpl with tests
3 years, 8 months ago (2017-04-07 20:21:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808563002/1
3 years, 8 months ago (2017-04-07 20:22:00 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/f5fa6d693cae9dfcdb66bdfd70752975c7d9bef4
3 years, 8 months ago (2017-04-07 20:33:24 UTC) #6
sdefresne
3 years, 8 months ago (2017-04-10 09:50:21 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698